Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 579424 - sys-kernel/gentoo-sources: GENTOO_LINUX_INIT_SYSTEMD should select DEVPTS_MULTIPLE_INSTANCES
Summary: sys-kernel/gentoo-sources: GENTOO_LINUX_INIT_SYSTEMD should select DEVPTS_MUL...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL:
Whiteboard: linux-4.1.23
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-09 11:48 UTC by Erik Quaeghebeur
Modified: 2017-03-05 21:49 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Quaeghebeur 2016-04-09 11:48:52 UTC
sys-apps/systemd-226-r2's pre-merge checks warned me

"CONFIG_DEVPTS_MULTIPLE_INSTANCES:   is not set when it should be."

while I have CONFIG_GENTOO_LINUX_INIT_SYSTEMD set. So GENTOO_LINUX_INIT_SYSTEMD should select DEVPTS_MULTIPLE_INSTANCES.
Comment 1 Mike Gilbert gentoo-dev 2016-04-13 14:42:44 UTC
Confirming this request. From the systemd README:

> Required for PrivateNetwork and PrivateDevices in service units:
>   CONFIG_NET_NS
>   CONFIG_DEVPTS_MULTIPLE_INSTANCES
> Note that systemd-localed.service and other systemd units use
> PrivateNetwork and PrivateDevices so this is effectively required.
Comment 2 Mike Pagano gentoo-dev 2016-04-19 15:12:54 UTC
This is already there:

+config GENTOO_LINUX_INIT_SYSTEMD
+   bool "systemd"
+
+   default n
+
+   depends on GENTOO_LINUX && GENTOO_LINUX_UDEV
+
+   select AUTOFS4_FS
+   select BLK_DEV_BSG
+   select CGROUPS
+   select DEVPTS_MULTIPLE_INSTANCES

Ran make defconfig and then diffed with GENTOO_LINUX set:

diff /tmp/def.config .config
17c17
< # CONFIG_GENTOO_LINUX_INIT_SYSTEMD is not set
---
> CONFIG_GENTOO_LINUX_INIT_SYSTEMD=y
1921c1921
< # CONFIG_DEVPTS_MULTIPLE_INSTANCES is not set
---
> CONFIG_DEVPTS_MULTIPLE_INSTANCES=y
3298c3298,3299
< # CONFIG_FANOTIFY is not set
---
> CONFIG_FANOTIFY=y
> # CONFIG_FANOTIFY_ACCESS_PERMISSIONS is not set

Am I missing something completely here?
Comment 3 Erik Quaeghebeur 2016-04-19 21:15:47 UTC
(In reply to Mike Pagano from comment #2)
> This is already there:
> 
> Am I missing something completely here?

Well, some information must be missing still in my report, I think that it is the 
kernel version: 4.1.15-r1. As far as I can see, it is present in 4.5.1, but not in 4.1.5-r2.
Comment 4 Mike Pagano gentoo-dev 2016-04-20 00:36:04 UTC
(In reply to Erik Quaeghebeur from comment #3)
> (In reply to Mike Pagano from comment #2)
> > This is already there:
> > 
> > Am I missing something completely here?
> 
> Well, some information must be missing still in my report, I think that it
> is the 
> kernel version: 4.1.15-r1. As far as I can see, it is present in 4.5.1, but
> not in 4.1.5-r2.

But it is in the latest 4.1.X release. 4.1.21.  

https://gitweb.gentoo.org/proj/linux-patches.git/commit/?h=4.1&id=f8fc60510d50d9fd52e4e90cc7516c393a341555
Comment 5 Erik Quaeghebeur 2016-04-20 07:51:02 UTC
(In reply to Mike Pagano from comment #4)
>
> But it is in the latest 4.1.X release. 4.1.21.  

To test, I emerged 4.1.21 and looked at the menuconfig screen for GENTOO_LINUX_INIT_SYSTEMD. No selection of DEVPTS_MULTIPLE_INSTANCES was apparent there.

> https://gitweb.gentoo.org/proj/linux-patches.git/commit/?h=4.
> 1&id=f8fc60510d50d9fd52e4e90cc7516c393a341555

I guess that was a copy-paste error? That patch is about optimization. I am not familiar enough with the web interface to find the patch that introduced the selection (for 4.5, or earlier), sorry.
Comment 6 Mike Pagano gentoo-dev 2016-04-20 10:05:02 UTC
(In reply to Erik Quaeghebeur from comment #5)
> (In reply to Mike Pagano from comment #4)
> >
> > But it is in the latest 4.1.X release. 4.1.21.  
> 
> To test, I emerged 4.1.21 and looked at the menuconfig screen for
> GENTOO_LINUX_INIT_SYSTEMD. No selection of DEVPTS_MULTIPLE_INSTANCES was
> apparent there.
> 
> > https://gitweb.gentoo.org/proj/linux-patches.git/commit/?h=4.
> > 1&id=f8fc60510d50d9fd52e4e90cc7516c393a341555
> 
> I guess that was a copy-paste error? That patch is about optimization. I am
> not familiar enough with the web interface to find the patch that introduced
> the selection (for 4.5, or earlier), sorry.


That's because I'm mixing bugs.  Maybe I was tired last night, sorry.

I'll look at the 4.1.X for the systemd settings soon.
Comment 7 Mike Pagano gentoo-dev 2016-04-22 18:06:32 UTC
Committed.

commit 53f63e4e0ebb503d06ae47030b9d66e1208de0e2
Author: Mike Pagano <mpagano@gentoo.org>
Date:   Fri Apr 22 14:05:58 2016 -0400

    Update for Gentoo specific distro patch. Select DEVPTS_MULTIPLE_INSTANCES when GENTOO_LINUX_INIT_SYSTEMD selected. Bug #579424.
Comment 8 Mark Gomersbach 2016-09-19 09:08:27 UTC
As of this patch https://patchwork.kernel.org/patch/8852011/ , 

It is not a option to select anymore.