Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 579298 - mail-client/mutt-1.6.0 — sidebar doesn’t compile
Summary: mail-client/mutt-1.6.0 — sidebar doesn’t compile
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Fabian Groffen
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-08 06:27 UTC by Floyd Anderson
Modified: 2016-04-12 18:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch for compiling Mutt 1.6.0 with NeoMutt sidebar patch (mutt-1.6.0.ebuild.patch,833 bytes, patch)
2016-04-09 18:32 UTC, Floyd Anderson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Floyd Anderson 2016-04-08 06:27:48 UTC
With sidebar USE-flag and “sidebar-neomutt.patch” (mutt-1.6.0-gentoo-patches-r3.tar.xz) patch applied,
the sidebar stuff isn’t compiled. Therefore command “mutt -v” still shows “-USE_SIDEBAR”.

Specifying “$(use_enable sidebar)” additionally for ${myconf} variable in src_configure() function in
mutt-1.6.0.ebuild solves the above issue. But I’m not a developer and therefore not very familar with
writing customized ebuilds, so I don’t know if this is the right way to go. 

BTW the link “http://www.mutt.org/doc/devel/manual.html” to Mutts manual page used in sed replacement
part (src_install() function) should be “http://www.mutt.org/doc/manual/”, because the former is dead
since upstream tagged Mutt 1.6.0 as stable.

Reproducible: Always

Steps to Reproduce:
1. USE="sidebar" emerge mail-client/mutt-1.6.0 
2.
3.
Actual Results:  
1. command: mutt -v shows -USE_SIDEBAR

Expected Results:  
1. command: mutt -v shows +USE_SIDEBAR
Comment 1 Ladislav Laska 2016-04-08 10:42:15 UTC
Yes, I can confirm this is the correct solution. 

The patch from neomut adds --enable-sidebar option to configure, while the old patch did not require it.
Comment 2 Oleh 2016-04-09 14:32:59 UTC
a neomutt sidebar patch allows only building. However, it does not fix runtime.


oleg@oleg2 ~ $ mutt
Error in .mutt/sidebar, line 5: sidebar_width: unknown variable
Error in .mutt/sidebar, line 6: sidebar_visible: unknown variable
Error in .mutt/sidebar, line 7: sidebar_delim: unknown variable
Error in .mutt/sidebar, line 8: sidebar_new: no such object
Error in .mutt/sidebar, line 10: sidebar-prev: no such function in map
Error in .mutt/sidebar, line 11: sidebar-next: no such function in map
Error in .mutt/sidebar, line 12: sidebar-open: no such function in map
Error in .mutt/sidebar, line 13: sidebar-prev: no such function in map
Error in .mutt/sidebar, line 14: sidebar-next: no such function in map
Error in .mutt/sidebar, line 15: sidebar-open: no such function in map
Error in /home/oleg/.muttrc, line 29: source: errors in .mutt/sidebar
source: errors in /home/oleg/.muttrc
Press any key to continue...

mutt-1.5.24-r2 does not exhibit such behavior. mutt-1.6.0 changelog does not mention sidebar changes (at least explicitly). I propose use mask sidebar for >=mutt-1.6.0 for time being.
Comment 3 Floyd Anderson 2016-04-09 18:32:10 UTC
Created attachment 430016 [details, diff]
ebuild patch for compiling Mutt 1.6.0 with NeoMutt sidebar patch
Comment 4 Floyd Anderson 2016-04-09 18:35:06 UTC
Comment on attachment 430016 [details, diff]
ebuild patch for compiling Mutt 1.6.0 with NeoMutt sidebar patch

First, thank you Ladislav (comment 1) to substantiate my guess, Mutt 1.6.0 with neomutt sidebar patch works now for me.

What has to be done was:
1.) building a local overlay
    a.) copy mutt-1.6.0.ebuild and also files directory to overlay
    b.) apply attached ebuild patch
    c.) generate/rebuild the overlay Manifest with: “ebuild mutt-1.6.0.ebuild manifest”
2.) compiling local overlay
    a.) with: “USE="sidebar" emerge \=mail-client/mutt-1.6.0”
3.) comparing config changes
    a.) from: <https://www.neomutt.org/sidebar-intro.html#intro-sidebar-config-changes>
    b.) modifying personal affected config

But for sure, I agree with you Oleg (comment 2), this is not what an average user expected. So my vote goes also to masking sidebar. Thanks for comments.
Comment 5 Fabian Groffen gentoo-dev 2016-04-12 05:05:09 UTC
Hmmm, bad testing on my part.  I don't like the options changed.  I'll look into an official sidebar release instead, if there will be any.
Comment 6 Fabian Groffen gentoo-dev 2016-04-12 18:58:34 UTC
Ok, in 1.6.0-r1 this should be enabled now with USE=sidebar.  Thanks!