579134 – www-clients/midori: Add libnotify use flag

Bug 579134 - www-clients/midori: Add libnotify use flag

Summary: www-clients/midori: Add libnotify use flag

Status:	RESOLVED INVALID

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	XFCE Team

URL:
Whiteboard:
Keywords:

Depends on:	579128
Blocks:
	Show dependency tree

Reported:	2016-04-06 02:52 UTC by cl91tp
Modified:	2016-08-22 10:18 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
patch for adding libnotify USE flag (midori-0.5.11-libnotify.patch,978 bytes, patch) 2016-04-06 02:52 UTC, cl91tp	Details \| Diff
resulting ebuild (midori-0.5.11-libnotify.ebuild,2.86 KB, text/plain) 2016-04-06 02:53 UTC, cl91tp	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description cl91tp 2016-04-06 02:52:06 UTC

Created attachment 429744 [details, diff]
patch for adding libnotify USE flag

Depends on bug #579128

Adds support for building midori without libnotify support.

Comment 1 cl91tp 2016-04-06 02:53:05 UTC

Created attachment 429746 [details]
resulting ebuild

Comment 2 Pacho Ramos gentoo-dev

2016-08-22 10:18:18 UTC

libnotify is always used in midori:
$ grep -r libnotif *
CMakeLists.txt:    pkg_check_modules(NOTIFY REQUIRED libnotify)
CMakeLists.txt:    set(PKGS ${PKGS} libnotify)
ChangeLog: Make libnotify mandatory except on Windows
ChangeLog: + Support libnotify 0.7
ChangeLog: + Turn libnotify into a proper build-time dependency
ChangeLog: + Use libnotify (runtime dependency) for finished transfers
README:              libsoup 2.27.90, sqlite 3.0, Vala 0.16, libnotify
midori/midori-view.c:    midori_view_add_version (markup, html, g_strdup_printf ("cairo %s (%s)\tlibnotify %s",
midori/midori-app.c:    #include <libnotify/notify.h>