Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 579066 - app-admin/logstash-bin-2.3.0: logrotate file has syntax errors
Summary: app-admin/logstash-bin-2.3.0: logrotate file has syntax errors
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Tomáš Mózes
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-05 04:51 UTC by Karl-Johan Karlsson
Modified: 2016-04-05 09:51 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karl-Johan Karlsson 2016-04-05 04:51:29 UTC
app-admin/logstash-bin ships a logrotate configuration file. In version 2.2, the first line, saying which files to rotate, looked like this:

   /var/log/logstash/*.log {

In version 2.3.0, it was changed to this:

   /var/log/logstash/*.{err,log} {

Which makes logrotate say:

   error: logstash:1 unknown option 'err' -- ignoring line

Because logrotate doesn't accept {} expansions in file names - a '{' character instead separates the file name from  the configuration directives. A correct line that would actually accomplish what it looks like the purpose was might be:

   /var/log/logstash/*.err /var/log/logstash/*.log {

But I don't see why the change was made at all, since according to the init script logstash only logs to one file:

   LS_LOG_FILE=${LS_LOG_FILE:-/var/log/logstash/logstash.log}
Comment 1 Karl-Johan Karlsson 2016-04-05 04:58:13 UTC
It looks like this bug affects app-admin/logstash-bin-2.2.2-r1 as well, but I haven't tested that version.
Comment 2 Tomáš Mózes 2016-04-05 06:38:55 UTC
Thanks for reporting the issues with the latest logstash bump. Patrick, as the author of this bump, promised he will take immediate actions to fix these problems.

Sorry for the trouble.
Comment 3 Patrick Lauer gentoo-dev 2016-04-05 09:51:33 UTC
Fixed.