Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 578664 - kde-plasma/plasma-desktop, kde-plasma/plasma-workspace no-baloo patches, interested y/n?
Summary: kde-plasma/plasma-desktop, kde-plasma/plasma-workspace no-baloo patches, inte...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-31 08:01 UTC by Duncan
Modified: 2016-10-08 16:28 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
plasma-desktop-kill-baloo.patch (plasma-desktop-kill-baloo.patch,1.34 KB, patch)
2016-03-31 08:01 UTC, Duncan
Details | Diff
plasma-workspace-kill-baloo.patch (plasma-workspace-kill-baloo.patch,936 bytes, patch)
2016-03-31 08:03 UTC, Duncan
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Duncan 2016-03-31 08:01:22 UTC
Created attachment 429338 [details, diff]
plasma-desktop-kill-baloo.patch

What's the gentoo/kde project's interest/position on a couple patches I have that disable the baloo support and deps for kde-plasma/plasma-desktop and plasma-workspace?

Given the additional modularity of kde5, these two packages are the only ones I have installed that require baloo, and it was easy enough to patch that out.  But gentoo/kde hasn't carried forward the semantic-desktop flag into kde/plasma5, and currently, baloo is a hard-dep of both these packages on gentoo, so I have to carry my own patches to disable it.

Obviously gentoo/kde would need to convert the disabling patches to a USE flag option, but the patches would still serve as a well tested starting point, for a base plasma desktop installation anyway, which would make it optional at least at the minimal end.

So any interest at all, or am I stuck with carrying the patches (and maintenance thereof) on my own?

FWIW:

The plasma-desktop patch consists of commenting out the five-line find_package(KF5Baloo ...) clause in the base CMakeLists.txt and the single-line add_subdirectory(baloo) line in kcms/CMakeLists.txt.

The plasma-workspace patch is even simpler, commenting out a single-line find_package(KF5 ... COMPONENTS Baloo) in the primary CMakeLists.txt, and another single-line add_subdirectory(baloo) in runners/CMakeLists.txt.

So they're not complex patches at all.  Easy enough to find and patch manually, which is what I did initially.  And they're tested as I've run them on a couple release updates, and now on live-9999, without issue.

I haven't bothered to kill the baloo deps in the ebuild, however, as at first I simply used package.provided, and now I have a simple 0-file-install baloo null-ebuild in my overlay, nicely filling the dep for portage while neither actually installing  any baloo files nor pulling in the couple of additional deps the real baloo package would pull in.

So the patches themselves are trivially recreated, but what they really do is demonstrate just how simple it is to eliminate baloo and its deps from a reasonably minimal frameworks/plasma base desktop, both in the patches, and in the fact that I've been running them here for several package updates, now, so they're actually tested to work.

But it sure would be nice not to have to carry the full burden of maintaining the patches over time, myself, if my gentoo/kde upstream can possibly be convinced to carry them.  Plus of course I think we demonstrated a reasonable interest in -semantic-desktop among the gentoo/kde userbase back when the kde4 attempt to remove them was made, so if/when the option is made available to others I'm sure there will be people besides me using it. =:^)

Plus then I wouldn't have to worry about the effect of the patches on any potential bugs I might find and file.

Tho the one fine_package line in plasma-workspace that I'm commenting out /does/ call it REQUIRED, so despite the current simplicity, it appears the option is is no longer supported upstream, which means continuing to support it in gentoo/kde isn't guaranteed to remain as simple as it happens to be ATM.  So if you prefer not to touch it as long as plasma upstream still considers it required, go ahead and resolve UPSTREAM, and I'll quit bothering gentoo/kde with it.

Tho a reference to an official upstream policy/comment on the issue would be useful in that case, if you have one handy.  No need to bother upstream with it if they've already declared it non-optional, and that's the way it is.

Thanks either way.  Others may find the patches useful even if gentoo/kde isn't interested, so I'm posting them, the plasma-desktop patch with this filing, the plasma-workspace patch in a moment.
Comment 1 Duncan 2016-03-31 08:03:20 UTC
Created attachment 429340 [details, diff]
plasma-workspace-kill-baloo.patch

The plasma-workspace patch.
Comment 2 Johannes Huber (RETIRED) gentoo-dev 2016-03-31 14:20:30 UTC
These patches hard disables the very useful desktop search. If you want a real build option improve your patch and send it to upstream via git.reviewboard.kde.org.