Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 578390 - sys-apps/baselayout should install a completely commented-out fstab
Summary: sys-apps/baselayout should install a completely commented-out fstab
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] baselayout (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: William Hubbs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-27 17:50 UTC by Mike Gilbert
Modified: 2016-08-25 19:11 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch (fstab.patch,2.48 KB, patch)
2016-08-25 16:25 UTC, Mike Gilbert
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Gilbert gentoo-dev 2016-03-27 17:50:43 UTC
baselayout currently installs fstab with invalid entries, expecting the user to replace them before booting.

Instead, I think we should install an fstab with commented-out examples.

This would allow stage tarballs to be used as pre-built container images for tools like systemd-machined without having ugly mount errors displayed when the container starts.
Comment 1 Mike Gilbert gentoo-dev 2016-03-27 17:55:32 UTC
An example of what I mean:

> floppym@naomi ~ % sudo systemd-nspawn -b -M stage3-amd64-systemd-20160323
> Spawning container stage3-amd64-systemd-20160323 on /var/lib/machines/stage3-amd64-systemd-20160323.
> Press ^] three times within 1s to kill container.
> systemd 226 running in system mode. (+PAM -AUDIT -SELINUX +IMA -APPARMOR +SMACK -SYSVINIT +UTMP -LIBCRYPTSETUP -GCRYPT -GNUTLS +ACL -XZ +LZ4 +SECCOMP +BLKID -ELFUTILS +KMOD -IDN)
> Detected virtualization systemd-nspawn.
> Detected architecture x86-64.
> 
> Welcome to Gentoo/Linux!
> 
> Running in a container, ignoring fstab device entry for /dev/BOOT.
> Running in a container, ignoring fstab device entry for /dev/ROOT.
> Running in a container, ignoring fstab device entry for /dev/SWAP.
> Running in a container, ignoring fstab device entry for /dev/cdrom.
> Running in a container, ignoring fstab device entry for /dev/fd0.
Comment 2 Mike Gilbert gentoo-dev 2016-08-25 16:25:43 UTC
Created attachment 444106 [details, diff]
patch

Here's a patch for this. I also included an update to add information on mounting by UUID.
Comment 3 William Hubbs gentoo-dev 2016-08-25 19:11:36 UTC
Added in commit 90edf00.
I also made the same change for  the bsd fstab and put it in the same
commit.

If someone wants to add the url to this bug for the commit feel free to
do so.