Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 577972 - www-client/firefox-45.0.1 needs some patches for arm64 support
Summary: www-client/firefox-45.0.1 needs some patches for arm64 support
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-22 03:25 UTC by Steev Klimaszewski (RETIRED)
Modified: 2017-08-26 17:55 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steev Klimaszewski (RETIRED) gentoo-dev 2016-03-22 03:25:54 UTC
Currently firefox 45.0.1 does not build for arm64, however with a few patches from upstream (and one that, afaik is not sent upstream yet,) it builds and runs with 

dbus ffmpeg gmp-autoupdate gstreamer hwaccel jemalloc3 jit startup-notification system-jpeg system-libvpx useflags set.

The 4 patches that I apply, I nicked from Debian.

https://anonscm.debian.org/cgit/pkg-mozilla/iceweasel.git/tree/debian/patches/fixes/Bug-1250403-Part-1.-Define-ARCH_CPU_ARM64-instead-of.patch

https://anonscm.debian.org/cgit/pkg-mozilla/iceweasel.git/tree/debian/patches/fixes/Bug-1250403-Part-2.-Import-crbug-354405-for-aarch64..patch

https://anonscm.debian.org/cgit/pkg-mozilla/iceweasel.git/tree/debian/patches/fixes/Bug-1252699-Set-WEBRTC_DETECT_ARM_NEON-when-optional.patch

https://anonscm.debian.org/cgit/pkg-mozilla/iceweasel.git/tree/debian/patches/fixes/Bug-1257888-Link-chromium-mutex-based-atomics-implem.patch

And then the 5th is to NOT use static sizes in jemalloc, which is based on https://anonscm.debian.org/cgit/pkg-mozilla/iceweasel.git/tree/debian/patches/porting/Make-powerpc-not-use-static-page-sizes-in-mozjemallo.patch but adds in !defined(__aarch64__) to it.  Otherwise Firefox will just segfault on an arm64 box that does not have 64k page sizes.


Lastly, I'm not entirely sure if this is an issue in the arm64 build, but I had firefox 38.7.1 installed and was getting the following during the install step:

Executing /var/tmp/portage/www-client/firefox-45.0.1/work/firefox-45.0.1/ff/dist/bin/xpcshell -g /var/tmp/portage/www-client/firefox-45.0.1/work/firefox-45.0.1/ff/dist/bin/ -a /var/tmp/portage/www-client/firefox-45.0.1/work/firefox-45.0.1/ff/dist/bin/ -f /var/tmp/portage/www-client/firefox-45.0.1/work/firefox-45.0.1/toolkit/mozapps/installer/precompile_cache.js -e precompile_startupcache("resource://gre/");
/var/tmp/portage/www-client/firefox-45.0.1/work/firefox-45.0.1/ff/dist/bin/xpcshell: /usr/lib64/firefox/libxul.so: version `xul45' not found (required by /var/tmp/portage/www-client/firefox-45.0.1/work/firefox-45.0.1/ff/dist/bin/xpcshell)

Once I removed firefox 38.7.1, it seemed to run correctly;
Comment 1 Ian Stakenvicius (RETIRED) gentoo-dev 2016-03-28 15:02:00 UTC
Thanks for the patches!  I'll try and review these within the next 24h.
Comment 2 Jory A. Pratt gentoo-dev 2016-03-29 00:09:32 UTC
(In reply to Ian Stakenvicius from comment #1)
> Thanks for the patches!  I'll try and review these within the next 24h.

Patches are sane and can be added without delay.
Comment 3 Steev Klimaszewski (RETIRED) gentoo-dev 2016-04-05 20:34:43 UTC
The patches are sane, however, there's still another issue somewhere in JIT :(
Comment 4 Ian Stakenvicius (RETIRED) gentoo-dev 2016-04-05 21:01:04 UTC
I expect https://bugzilla.mozilla.org/show_bug.cgi?id=972710 is somewhat relevant here.
Comment 5 Ian Stakenvicius (RETIRED) gentoo-dev 2016-06-08 02:59:06 UTC
There has been a few versions since this bug was posted, please check newer versions and let me know if more patches are needed
Comment 6 Jory A. Pratt gentoo-dev 2017-08-26 17:55:29 UTC
If you feel I have closed your bug and it is still a current issue, please reopen and update it completely. We will not work bugs that have no ebuild in tree any longer or can not be reproduced with a current system.

Thank You for your support and understanding
The Mozilla Team