Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 577796 - x11-wm/enlightenment-0.20.6[wayland] - No rule to make target 'src/modules/wl_weekeyboard/themes/default/default_600.edj'
Summary: x11-wm/enlightenment-0.20.6[wayland] - No rule to make target 'src/modules/wl...
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Joonas Niilola
URL: https://phab.enlightenment.org/T3228
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2016-03-19 23:28 UTC by Dennis Schridde
Modified: 2018-07-10 05:01 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,93.92 KB, text/plain)
2016-03-19 23:28 UTC, Dennis Schridde
Details
emerge --info 'x11-wm/enlightenment:0.17' (file_577796.txt,6.87 KB, text/plain)
2016-05-01 17:08 UTC, Thibaud CANALE
Details
patch for the 0.20.6 ebuild (enlightenment-0.20.6.ebuild-T3228.patch,944 bytes, patch)
2016-05-01 20:22 UTC, Dennis Schridde
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Schridde 2016-03-19 23:28:07 UTC
Created attachment 428620 [details]
build.log

/usr/bin/edje_cc -v -DLOWRES_PDA=1 -DMEDIUMRES_PDA=2 -DHIRES_PDA=3 -DSLOW_PC=4 -DMEDIUM_PC=5 -DFAST_PC=6 -DE_PROFILE=SLOW_PC -id ./src/modules/tiling/images src/modules/tiling/e-module-tiling.edc src/modules/tiling/e-module-tiling.edj
make[2]: *** No rule to make target 'src/modules/wl_weekeyboard/themes/default/default_600.edj', needed by 'all-am'.  Stop.
make[2]: *** Waiting for unfinished jobs....
Comment 1 Dennis Schridde 2016-03-19 23:29:06 UTC
See-Also: https://phab.enlightenment.org/T3228
Comment 2 Thibaud CANALE 2016-05-01 17:08:18 UTC
Created attachment 432856 [details]
emerge --info 'x11-wm/enlightenment:0.17'

Hello,

Same error with hardened system.
Comment 3 Thibaud CANALE 2016-05-01 17:16:46 UTC
Here some info about the USE flags:

[ebuild  N     ] x11-wm/enlightenment-0.20.5:0.17/0.20.5::gentoo  USE="nls pam udev wayland -doc -spell -static-libs -systemd -ukit" ENLIGHTENMENT_MODULES="appmenu backlight battery bluez4 clock conf conf-applications conf-bindings conf-dialogs conf-display conf-interaction conf-intl conf-menus conf-paths conf-performance conf-randr conf-shelves conf-theme conf-window-manipulation conf-window-remembers connman cpufreq everything fileman fileman-opinfo gadman geolocation ibar ibox lokker mixer msgbus music-control notification packagekit pager pager-plain policy-mobile quickaccess shot start syscon systray tasks teamwork temperature tiling winlist wizard wl-desktop-shell wl-drm wl-text-input wl-weekeyboard wl-wl wl-x11 xkbswitch xwayland" 0 KiB

[ebuild   R    ]  dev-libs/efl-1.17.0::gentoo  USE="X bmp drm eet egl fontconfig gif gles glib gnutls gstreamer harfbuzz ico nls oldlua png ppm psd pulseaudio sound ssl tiff wayland xim -debug -doc -fbcon -fribidi -ibus -jpeg2k (-libressl) (-neon) -opengl -physics (-pixman) -scim -sdl -systemd -tga -tslib -v4l -valgrind -webp -xine -xpm" 0 KiB
Comment 4 Thibaud CANALE 2016-05-01 18:12:02 UTC
Update: Same error with version 0.20.6.
Comment 5 Thibaud CANALE 2016-05-01 18:32:49 UTC
See this commit, which seams to correct a typography, but the same error is still there.
https://git.enlightenment.org/core/enlightenment.git/commit/?id=008a3a81521876d32bd17ba25b237d4f5d695be9
Comment 6 Thibaud CANALE 2016-05-01 18:39:39 UTC
in the current archive, inside the repertory src/modules/wl_weekeyboard/themes/default/, there is the following files:
default_1080.edj  default_600.edc  default_720.edj

but in the current git (which is based currently on version 0.20.7), the content is more different:
https://git.enlightenment.org/core/enlightenment.git/tree/src/modules/wl_weekeyboard/themes/default?id=008a3a81521876d32bd17ba25b237d4f5d695be9
Comment 7 Dennis Schridde 2016-05-01 20:03:49 UTC
(In reply to Thibaud "thican" CANALE from comment #6)
> in the current archive, inside the repertory
> src/modules/wl_weekeyboard/themes/default/, there is the following files:
> default_1080.edj  default_600.edc  default_720.edj
> 
> but in the current git (which is based currently on version 0.20.7), the
> content is more different:
> https://git.enlightenment.org/core/enlightenment.git/tree/src/modules/
> wl_weekeyboard/themes/default?id=008a3a81521876d32bd17ba25b237d4f5d695be9

The error, which the patch corrects, is that the .edj file would not end up in the release tarball. Thus you cannot fix the issue by applying the patch to the released sources (tarball). Instead you have to apply it to the Git sources and produce a new (fixed) tarball.
Comment 8 Dennis Schridde 2016-05-01 20:04:48 UTC
P.S: The fix appears first in v0.21.0-beta: https://phab.enlightenment.org/rE008a3a81521876d32bd17ba25b237d4f5d695be9
i.e. all versions after that should not suffer from the issue.
Comment 9 Thibaud CANALE 2016-05-01 20:09:48 UTC
(In reply to Dennis Schridde from comment #7)
> The error, which the patch corrects, is that the .edj file would not end up
> in the release tarball. Thus you cannot fix the issue by applying the patch
> to the released sources (tarball). Instead you have to apply it to the Git
> sources and produce a new (fixed) tarball.

Yes, indeed, this is something someone told me on enlightenment's IRC channel, but I didn't understand it before.

(In reply to Dennis Schridde from comment #8)
> P.S: The fix appears first in v0.21.0-beta:
> https://phab.enlightenment.org/rE008a3a81521876d32bd17ba25b237d4f5d695be9
> i.e. all versions after that should not suffer from the issue.

This link is not a public one, we can't see it's content without authentication.

What about doing an "9999" ebuild linked to git? Do you know when this 0.21 version will be released?

Thanks for the answers.
Comment 10 Dennis Schridde 2016-05-01 20:18:28 UTC
(In reply to Thibaud "thican" CANALE from comment #9)
> Do you know when this 0.21 version will be released?

The beta was tagged 5 days ago: https://git.enlightenment.org/core/enlightenment.git/tag/?h=v0.21.0-beta
Comment 11 Dennis Schridde 2016-05-01 20:22:26 UTC
Created attachment 432872 [details, diff]
patch for the 0.20.6 ebuild

P.P.S. What we could do right now to fix this for v0.20.6, is add https://git.enlightenment.org/core/enlightenment.git/plain/src/modules/wl_weekeyboard/themes/default/default_600.edj?h=v0.20.6 to SRC_URI and just copy it to the appropriate folder in src_prepare(). Attached patch implements this.
Comment 12 Dennis Schridde 2016-05-01 20:23:28 UTC
(In reply to Dennis Schridde from comment #11)
> Created attachment 432872 [details, diff] [details, diff]
> patch for the 0.20.6 ebuild

Works for me. Please test.
Comment 13 Thibaud CANALE 2016-05-01 21:43:25 UTC
(In reply to Dennis Schridde from comment #12)
> (In reply to Dennis Schridde from comment #11)
> > Created attachment 432872 [details, diff] [details, diff] [details, diff]
> > patch for the 0.20.6 ebuild
> 
> Works for me. Please test.

Works for me.

Thanks.
Comment 14 Robert Spillner 2018-05-24 14:58:18 UTC
This also needs to be fixed for the 0.20.5 ebuild, same error there.
Comment 15 Joonas Niilola gentoo-dev 2018-06-15 14:38:25 UTC
Im not 100 % sure, but I think whether this builds or not, wl-weekeyboard module doesnt work. There should (have) be(en) work done for a new wl keyboard module. 

So to fix this in the tree I would disable wl-weekeyboard altogether, unless someone can confirm that the module works.

... Although Im trying to stabilize 0.21.11 which then helps to remove these old 0.20 versions.
Comment 16 Joonas Niilola gentoo-dev 2018-07-10 05:01:55 UTC
Closing, as the offending versions aren't in the tree anymore. Fixed upstream with ebuilds currently present in the tree. Thanks!