Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 577592 - mail-client/trojita-9999: add USE=crypto
Summary: mail-client/trojita-9999: add USE=crypto
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Jan Kundrát (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on: 577644
Blocks:
  Show dependency tree
 
Reported: 2016-03-16 23:02 UTC by Erik Quaeghebeur
Modified: 2016-03-18 11:20 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Updated live ebuild for mail-client/trojita (trojita-9999.ebuild,1.69 KB, text/plain)
2016-03-16 23:02 UTC, Erik Quaeghebeur
Details
Diff of the patch that adds crypto support to the Trojità live ebuild (trojita-9999.ebuild.diff,779 bytes, patch)
2016-03-17 12:28 UTC, Erik Quaeghebeur
Details | Diff
add-crypto-trojita-ebuild.patch (add-crypto-trojita-ebuild.patch,880 bytes, patch)
2016-03-17 15:42 UTC, Jan Kundrát (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Quaeghebeur 2016-03-16 23:02:17 UTC
Created attachment 428394 [details]
Updated live ebuild for mail-client/trojita

Recently, functionality for PGP-signed and encrypted message parts has been added to the development version of Trojità. This requires kde-apps/gpgmepp:5 and dev-libs/mimetic.

In attachment, I provide an updated live ebuild, in which the use flag ‘crypto’ determines inclusion of this functionality. (‘crypto’ and not ‘pgp’ because S/MIME functionality building on the is in the pipeline; ‘gpg’ would be another option, as the S/MIME functionality also builds on gpgmepp, but that may not be generic enough to cover inclusion of mimetic.)

I have emerged this ebuild successfully on amd64 and did a limited test of its functionality (looking at a pgp-signed message and getting the message that the signature could not be verified due to the key missing from my keychain).
Comment 1 Agostino Sarubbo gentoo-dev 2016-03-17 10:11:40 UTC
Please post the diff.
Comment 2 Erik Quaeghebeur 2016-03-17 12:28:18 UTC
Created attachment 428414 [details, diff]
Diff of the patch that adds crypto support to the Trojità live ebuild

Replaced full ebuild by diff and replaced (erroneously used) personal repository by the canonical one.
Comment 3 Jan Kundrát (RETIRED) gentoo-dev 2016-03-17 15:42:21 UTC
Created attachment 428458 [details, diff]
add-crypto-trojita-ebuild.patch

Erik, thanks a lot. I've updated your patch so that the ebuild now controls all flags which actually enable/enforce the availability of the required libs (I suspect that my cmake is terrible, but hey, that's what we have). I've also grouped the deps together because that's what I saw in other ebuilds, and changed the USE to default to on so that users have it as an opt-out, not as an opt-in.
Comment 4 Jan Kundrát (RETIRED) gentoo-dev 2016-03-17 15:44:34 UTC
@kensington, I suspect that this might require adding the ~x86 keyword to dev-libs/mimetic. Can you do that, please?

I would also appreciate some review of the changes, I'm not that strong with ebuilds.
Comment 5 Michael Palimaka (kensington) gentoo-dev 2016-03-17 15:52:20 UTC
(In reply to Jan Kundrát from comment #4)
> @kensington, I suspect that this might require adding the ~x86 keyword to
> dev-libs/mimetic. Can you do that, please?

Unfortunately I don't have x86 right now to test on. A keyword request can be filed to that team however.

> I would also appreciate some review of the changes, I'm not that strong with
> ebuilds.

The changes look good, although I would personally sort the dependencies alphabetically.
Comment 6 Michael Palimaka (kensington) gentoo-dev 2016-03-18 11:20:05 UTC
Thanks, fixed in git.

I switched 'crypto' to 'crypt' since the latter is already a global flag that seems to fit.

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b3c997001a1cefc5dd27de7df47d4640cb842b05