Bug 577244 – cmake-utils: check for dev-util/ninja doesn't expect ROOT changing

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Denis Sokolovsky 2016-03-12 21:52:39 UTC]

Build of sys-devel/llvm failed when I set ROOT to something different from "/" with error:

>>> Configuring source in /var/root-isis/tmp/portage/sys-devel/llvm-3.7.1/work/llvm-3.7.1.src ...
 * abi_x86_32.x86: running multilib-minimal_abi_src_configure
>>> Working in BUILD_DIR: "/var/root-isis/tmp/portage/sys-devel/llvm-3.7.1/work/llvm-3.7.1.src-abi_x86_32.x86"
 * ERROR: sys-devel/llvm-3.7.1::gentoo failed (configure phase):
 *   CMAKE_MAKEFILE_GENERATOR is set to ninja, but ninja is not installed. Please install dev-util/ninja or unset CMAKE_MAKEFILE_GENERATOR.

Failed check if "if ! has_version dev-util/ninja; then" at line 245, which search "dev-util/ninja" in ROOT (which set to "/var/root-isis"), which contain only RDEPEND.

As far as I understand this check should be changed to "... ROOT=/ has_version ..." or something like that.

[Comment 1 Michael Palimaka (kensington) 2016-03-20 18:15:54 UTC]

@ottxor, I think you handled some ninja stuff in the past - any thoughts?

[Comment 2 Christoph Junghans (RETIRED) 2016-03-20 22:58:07 UTC]

Yeah, I guess the check should be "ROOT=/ has_versiondev-util/ninja" (in the same way as we look for cmake itself).

[Comment 3 Michael Palimaka (kensington) 2016-03-22 16:03:26 UTC]

Thanks, in overlay for testing.

https://gitweb.gentoo.org/proj/kde.git/commit/?id=6a842b75825a439bf7c9ee11ad9686a5d163f3d3

[Comment 4 Michael Palimaka (kensington) 2016-04-02 14:51:19 UTC]

Thanks, fixed in git.

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=385fc99384fe36e940a814545e9e85ccba2d4ef4