Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 576986 - kde-base/kdeplasma-addons: Add IUSE eigen
Summary: kde-base/kdeplasma-addons: Add IUSE eigen
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-10 18:36 UTC by Alexander Stein
Modified: 2016-03-26 11:35 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch making dev-cpp/eigen:2 optional (kdeplasma.diff,1.61 KB, patch)
2016-03-10 18:37 UTC, Alexander Stein
Details | Diff
patch making dev-cpp/eigen:2 optional (kdeplasma.diff,1.91 KB, patch)
2016-03-10 21:54 UTC, Alexander Stein
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Stein 2016-03-10 18:36:52 UTC
Using the attached patch the build time dependency dev-cpp/eigen:2 is made optional. If eigen is found during CMake configure the mandelbrot wallpaper plugin will be built, otherwise it will be skipped.
Comment 1 Alexander Stein 2016-03-10 18:37:35 UTC
Created attachment 427916 [details, diff]
patch making dev-cpp/eigen:2 optional
Comment 2 Andreas Sturmlechner gentoo-dev 2016-03-10 19:04:26 UTC
Your patch is introducing an automagic dependency, regardless if you set USE=eigen or not: Will build mandelbrot if Eigen2 is found by configure, won't do otherwise.

You need to add the required cmake switch to disable find_package(Eigen2 2.0.3)
Comment 3 Alexander Stein 2016-03-10 21:38:29 UTC
(In reply to Andreas Sturmlechner from comment #2)
> Your patch is introducing an automagic dependency, regardless if you set
> USE=eigen or not: Will build mandelbrot if Eigen2 is found by configure,
> won't do otherwise.
> 
> You need to add the required cmake switch to disable find_package(Eigen2
> 2.0.3)

Yep, I noticed that too. I considered this unharmfull, as eigen is a built-time library only. If it is available fine, if not do not pull it in. Unless yout want to achieve eigen is not even touched even if it is available.
Comment 4 Andreas Sturmlechner gentoo-dev 2016-03-10 21:46:37 UTC
It means that USE=-eigen will yield the same as USE=eigen when it is installed, the flag should work both ways.
Comment 5 Alexander Stein 2016-03-10 21:54:36 UTC
Created attachment 427934 [details, diff]
patch making dev-cpp/eigen:2 optional

Updated version adding a call to utils_use_find_package actually ignoring any installed dev-cpp/eigen:2
Comment 6 Andreas Sturmlechner gentoo-dev 2016-03-25 16:12:05 UTC
Gave it a try and it works fine.