576716 – sys-process/criu-1.8 installs python package but does not depend on it

Bug 576716 - sys-process/criu-1.8 installs python package but does not depend on it

Summary: sys-process/criu-1.8 installs python package but does not depend on it

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Yixun Lan

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2016-03-07 15:58 UTC by Alexis Ballier
Modified:	2016-03-15 15:14 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alexis Ballier gentoo-dev

2016-03-07 15:58:41 UTC

$ portageq metadata / ebuild sys-process/criu-1.8 DEPEND RDEPEND
dev-libs/protobuf-c setproctitle? ( dev-libs/libbsd ) app-text/asciidoc app-text/xmlto
dev-libs/protobuf-c setproctitle? ( dev-libs/libbsd )


$ equery files criu | grep python
/usr/lib64/python2.7
/usr/lib64/python2.7/site-packages
/usr/lib64/python2.7/site-packages/crit-0.0.1-py2.7.egg-info
/usr/lib64/python2.7/site-packages/pycriu
/usr/lib64/python2.7/site-packages/pycriu/__init__.py
/usr/lib64/python2.7/site-packages/pycriu/criu.py
/usr/lib64/python2.7/site-packages/pycriu/images


etc.


not sure how to properly add python support ebuild-wise for this one, so CC'ing python herd

Comment 1 Justin Lecher (RETIRED) gentoo-dev

2016-03-07 20:55:38 UTC

The makefile under lib shouldn't install the python stuff (lib-py target) and the python_domodule() should be used to install the module instead. As dep you need PYTHON_DEPS. Perhaps everything should be covert by USE=python.

Comment 2 Alexis Ballier gentoo-dev

2016-03-15 15:14:02 UTC

commit 5fcb6dedbe1b7a139ff1951f9964baaebb2ba3ef
Author: Alexis Ballier <aballier@gentoo.org>
Date:   Tue Mar 15 16:01:08 2016 +0100

    sys-process/criu: Add python useflag and fix build with LDFLAGS not matching default.
    
    Adapt makefile patch to use RAW_LDFLAGS for ld which we feed from ebuild.
    Patch makefile to allow disabling python and make it optional with proper deps, bug #576716.


not exactly what you said but should convey the same idea, thanks!