Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 576672 - www-client/chromium needs 2 patches for arm64 support to work properly
Summary: www-client/chromium needs 2 patches for arm64 support to work properly
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Chromium Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-07 07:34 UTC by Steev Klimaszewski (RETIRED)
Modified: 2016-03-09 16:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steev Klimaszewski (RETIRED) gentoo-dev 2016-03-07 07:34:56 UTC
Recently I keyworded chromium for arm64 support, and noted that you need to pass --no-sandbox in order to use it.  Turns out there are 2 patches that have been reviewed that need to be added, to make sandboxing and chromium work properly.

https://codereview.chromium.org/1613883002

and 

https://codereview.chromium.org/1617763002

I'm not sure how the chromium team does their patching, so for the moment, I just have them in my overlay (pulled them from Arch Linux where Kevin took my positive results of getting it to build and went further to figure out what was failing)
Comment 1 SpanKY gentoo-dev 2016-03-07 16:34:48 UTC
both have been merged into the main repo, so there should be no need to carry patches ... just update/wait for the newer version
Comment 2 Mike Gilbert gentoo-dev 2016-03-07 16:36:59 UTC
Nice work digging that up. I tried to apply these changes from git.

4e8083b4ab953ba298aedfc4e79d464be15e4012 fails to apply against 49.0.2623.75.

https://crrev.com/4e8083b4ab953ba298aedfc4e79d464be15e4012

f352d974e43a73fed311c60c8fcb4dd043b16093 seems to work.

https://crrev.com/f352d974e43a73fed311c60c8fcb4dd043b16093

If you can provide a working patch for the first change, we can apply the patches in a revbump.

Otherwise, we wait until the changes roll into a release, likely chromium-51.
Comment 3 Steev Klimaszewski (RETIRED) gentoo-dev 2016-03-07 17:31:49 UTC
I used the patches from ARCH, which would be 

https://github.com/archlinuxarm/PKGBUILDs/blob/master/extra/chromium/0002-sandbox-arm64-align-stack-16-bytes.patch

and

https://github.com/archlinuxarm/PKGBUILDs/blob/master/extra/chromium/0003-Linux-Sandbox-whitelist-arm64-syscalls.patch

I'm not sure why they didn't apply for you, I was just hoping to get this working since arm64 hardware is starting to land in users hands (my C2 that I ordered when they became available for pre-order arrives today).
Comment 4 Mike Gilbert gentoo-dev 2016-03-07 18:03:08 UTC
(In reply to Steev Klimaszewski from comment #3)

At a glance version committed on upstream master includes an additional file which does not exist in chromium-49.

mojo/shell/runner/host/linux_sandbox.cc

I'll try dropping that chunk.
Comment 5 Mike Gilbert gentoo-dev 2016-03-09 16:53:06 UTC
Fixed in 49.0.2623.75-r1.