Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 576086 - sys-apps/less-482: arrow keys don't work
Summary: sys-apps/less-482: arrow keys don't work
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-01 10:03 UTC by Michał Górny
Modified: 2016-03-15 19:23 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log (sys-apps:less-482:20160301-084343.log,17.48 KB, text/x-log)
2016-03-01 10:03 UTC, Michał Górny
Details
less-482-keepkeys.patch (less-482-keepkeys.patch,756 bytes, patch)
2016-03-01 15:31 UTC, Jouni Kosonen
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-03-01 10:03:31 UTC
Created attachment 427070 [details]
Build log

After upgrading to less-482, I'm no longer able to scroll manpages using arrow keys and pageup/pagedn. I can reproduce this with xfce4-terminal (TERM=xterm) and Linux console. -481 works fine.
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2016-03-01 10:20:53 UTC
# grep -B 2 "sys-apps/less" package.mask
# Lars Wendler <polynomial-c@gentoo.org> (01 Mar 2016)
# Arrow keys don't work (bug #576086).
=sys-apps/less-482
Comment 2 jospezial 2016-03-01 12:22:18 UTC
If I press the POS1 key ("home" on englisch keyboard?) then the help comes.
Comment 3 Jouni Kosonen 2016-03-01 15:31:09 UTC
Created attachment 427126 [details, diff]
less-482-keepkeys.patch

Version 482 moves the key allocation before terminal type configuration, presumably because it's supposed to happen before setting the secure mode.

It's pretty much the only functional change in the code, the rest is Unicode database updates.

My guess would be that the terminfo handling clobbers the default key definitions.

Reordering the initialisation to match what was in 481 but bringing the secure mode setting there as well does seem to restore the cursor key functionality.
Comment 4 SpanKY gentoo-dev 2016-03-01 19:50:22 UTC
(In reply to Jouni Kosonen from comment #3)

this should be e-mailed upstream instead.  i don't see us carrying these kind of patches.
Comment 5 Jouni Kosonen 2016-03-01 20:01:50 UTC
(In reply to SpanKY from comment #4)
> this should be e-mailed upstream instead.  i don't see us carrying these
> kind of patches.

That's true, email sent.
Comment 6 Jouni Kosonen 2016-03-01 21:31:57 UTC
Relayed on request:

On 01.03.2016 20:32 UTC, Mark Nudelman wrote:
> Hi Jouni,
> I am aware that this version broke keymappings and am working on a
> solution.  However I'm not sure why anyone is using less-482.  This
> was an experimental version which was not announced anywhere and was
> not intended for use by anyone except me.  Perhaps I should avoid
> posting experimental versions under predictable filenames.
>
> --Mark
Comment 7 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2016-03-15 13:13:02 UTC
Package has been removed from the tree.
Comment 8 SpanKY gentoo-dev 2016-03-15 19:23:34 UTC
(In reply to Jouni Kosonen from comment #6)

i've found less announcements to be pretty unreliable, so going to his site and looking has been the only way to find out about new versions ...

(In reply to Lars Wendler (Polynomial-C) from comment #7)

well, just that version :)