Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 575838 - app-editors/bluefish-2.2.8 version bump
Summary: app-editors/bluefish-2.2.8 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Nick Andrade
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-27 17:59 UTC by Nick Andrade
Modified: 2016-03-29 06:06 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
bluefish-2.2.8.ebuild (bluefish-2.2.8.ebuild,2.45 KB, text/plain)
2016-02-27 17:59 UTC, Nick Andrade 		Details
bluefish_2.2.7_vs_2.2.8.patch (bluefish_2.2.7_vs_2.2.8.patch,1.77 KB, patch)
2016-02-27 18:00 UTC, Nick Andrade 		Details | Diff
metadata.xml.patch (metadata.xml.patch,652 bytes, patch)
2016-02-27 18:21 UTC, Nick Andrade 		Details | Diff
bluefish-2.2.8.ebuild.patch (bluefish-2.2.8.ebuild.patch,1.32 KB, patch)
2016-03-29 04:06 UTC, Nick Andrade 		Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Andrade 2016-02-27 17:59:33 UTC 
Created attachment 426776 [details]
bluefish-2.2.8.ebuild

New ebuild for bluefish 2.2.8 which was released last month.  This new ebuild includes the option to build with GTK2 instead although GTK3 is the default.
Comment 1 Nick Andrade 2016-02-27 18:00:39 UTC 
Created attachment 426778 [details, diff]
bluefish_2.2.7_vs_2.2.8.patch

A diff to compare the current ebuild in Portage (2.2.7) to the attachment (2.2.8) to help highlight the changes.
Comment 2 Nick Andrade 2016-02-27 18:21:06 UTC 
Created attachment 426780 [details, diff]
metadata.xml.patch

Patch to update the current metadata.xml for the new USE flags.
Comment 3 Ian Delaney (RETIRED) gentoo-dev 2016-03-08 07:23:38 UTC 
Nick

somehow you have set keywords from testing to stable in the bump

-KEYWORDS="~alpha ~amd64 ~ia64 ~ppc ~ppc64 ~sparc ~x86"
+KEYWORDS="~alpha amd64 ~ia64 ~ppc ~ppc64 ~sparc x86"

-IUSE="gucharmap nls python spell"
+IUSE="gtk2 +gtk3 gucharmap nls python spell"
looks fine

There is also a minor whitespace issue in the  bluefish-2.2.8.ebuild as well.

Please fix and re-submit the bump to  bluefish-2.2.8 by a unified diff patch.
Comment 4 Nick Andrade 2016-03-29 02:59:26 UTC 
(In reply to Ian Delaney from comment #3)
> Nick
> 
> somehow you have set keywords from testing to stable in the bump
> 
> -KEYWORDS="~alpha ~amd64 ~ia64 ~ppc ~ppc64 ~sparc ~x86"
> +KEYWORDS="~alpha amd64 ~ia64 ~ppc ~ppc64 ~sparc x86"
> 
> -IUSE="gucharmap nls python spell"
> +IUSE="gtk2 +gtk3 gucharmap nls python spell"
> looks fine
> 
> There is also a minor whitespace issue in the  bluefish-2.2.8.ebuild as well.
> 
> Please fix and re-submit the bump to  bluefish-2.2.8 by a unified diff patch.

Ah, good catch, thanks for the feedback, I'll have an update posted shortly.
Comment 5 Nick Andrade 2016-03-29 04:06:30 UTC 
Created attachment 429210 [details, diff]
bluefish-2.2.8.ebuild.patch

A patch against bluefish-2.2.7 for the 2.2.8 release.
Comment 6 Sam Jorna (wraeth) gentoo-dev 2016-03-29 06:06:02 UTC 
My buidtesting of this was clean, however there were a couple of minor changes
to the ebuild to make - given they were only small, I took the liberty of fixing
these while committing rather than pushing back and waiting for another patch.

The changes to the ebuild were:
 - bump to EAPI6
 - reorder dependencies
 - replace `find ...` with `prune_libtool_files`

If you have any queries about these, please let me know.


commit 7655d0d8398a8370fc3f10781f994a46ab4d45f6
Author: Sam Jorna <wraeth@gentoo.org>
Date:   Tue Mar 29 17:01:16 2016 +1100

    app-editors/bluefish: bump to 2.2.8
    
    Version bump to 2.2.8, bump to EAPI6, add new USE flags for GTK+-2/3.
    
    Gentoo-bug: 575838
    Package-Manager: portage-2.2.28