Hi, some days ago I released Kwave v0.9.1 (built on KDE Frameworks 5). Please find the attached ebuild. regards, Thomas Reproducible: Always
Created attachment 426740 [details] kwave-0.9.1.ebuild
A 0.9.1 ebuild is already in kde overlay, how does it compare with your ebuild? https://github.com/gentoo/kde/commit/f545a150d22edcfe79d5b3b58674737bf34b5005
interesting... I did not know about that one. It has been ported to EAPI=6, but seems to lack proper documentation support, some dependencies are missing, qtmedia use flag is missing, project description is out of date, slot is missing, and the LICENSES file is missing.
- Documentation and SLOT are handled by kde5.eclass (usage of KDE_HANDBOOK has changed compared to kde4-base.eclass) - There's usually no need to copy license files since they would only be duplicated (see /usr/portage/licenses).
I couldn't find differences wrt dependencies (qtcore is added by kde5.eclass already) except for how many of them are in RDEPEND - most of these frameworks and Qt dependencies should be in there, but revisiting lddtree and the ebuild, I've found a few that are at least not required runtime, maybe are also bogus at build time? - GuiAddons - Init - Notifications - Service (doesn't end up linked in kwave_core because of --as-needed)
Thanks for your suggestions and pointing out the superflous build dependencies! I merged most of your changes into my ebuild template and it seems that nothing got broken :) However, I still have some differences: 1) what about the KDE_LINGUAS=... list, is it really safe to omit that line? 2) the "DESCRIPTION" tag should be: "A sound editor built on KDE Frameworks 5 that can edit many types of audio files." (just to use the same string in all places) 3) I removed the dependencies to kguiaddons, kinit, knotifications, kservice, qtconcurrent, qtgui, qtwidgets (as you already suggested) 4) "(add_kdeapps_dep poxml)" does not work here, complains about an unresolvable dependency. Probably because I am using the main repo only, not the kde overlay, and there I can find the right package, but not with the slot :5 -> so I am stuck with "kde-apps/poxml" for the time being, which matches to kde-apps/poxml-15.08.3 5) the "LICENSES" file: this has nothing to do with the stuff in /usr/portage/licenses, this is NOT a copy of a license text, it is a list of source files and their license + a list of licenses. It is _not_ ok to remove that! I remember I already had this discussion some time ago, so what could I do to make it clear? Any suggestion about how to rename that file to avoid this misunderstanding in future?
1) Yes, LINGUAS is indeed still a TODO, again kde5.eclass would normally do the work when it finds a po directory, but it only deals with ready generated language dirs. 4) poxml:5 currently remains masked in kde overlay but it's there, that's why I also needed to mask kwave in package.mask for the time being. 5) Thx for the heads up and I've added it. Maybe Readme.LICENSES would make it a bit clearer. Adapted to your other changes.
Created attachment 427134 [details] kwave-0.9.1.ebuild, updated to EAPI=6
Ok, I think we are getting closer. I still have to do that hack in src_prepare(), otherwise no GUI translations get installed, because some strange thing deletes everything from the po directory before cmake is called. Is this version acceptable?
I've worked a bit on that, so that you can drop KDE_LINGUAS (doesn't do anything) and the src_prepare hack (did work because it dropped the call to kde5_src_prepare), it is currently for review: https://github.com/gentoo/kde/pull/611
Updated kwave ebuild is pending for kde overlay: https://github.com/gentoo/kde/pull/620 - added sys-devel/gettext build time dependency - made qtmultimedia optional (what do you think?): https://git.reviewboard.kde.org/r/127311/ - src_prepare override not necessary anymore Qt5Gui and Qt5Widgets are still required (eclass only adds Core). poxml:5 should soon enter the tree, then it should be easy for kwave as well :)
Thanks all. https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a60f89f33356a74de5f7405d42b7d43d96daac2e
