Created attachment 426268 [details] Apache Configuration File Upon installing mod_xml2enc, it does not immediately work. It also does not work after adding "-D XML2ENC" to APACHE2_OPTS. Attached is a tiny configuration file that ensures that the module is loaded. Other packages (mod_evasive, mod_ssl, mod_security) have these files and it was confusing to find that mod_xml2enc didn't have this.
Hello Matthew, this package lacks a maintainer, would you like to proxy maintain it?
Just a heads up, I had to add an additional line before the "LoadModule" line of: LoadFile /usr/lib/libxml2.so otherwise I was recieving the error of: Cannot load modules/mod_xml2enc.so into server: /usr/lib64/apache2/mod_xml2enc.so: undefined symbol: xmlParseCharEncoding As a side note, it appears that mod_xml2enc might now be a dependancy of mod_proxy_html because, without mod_xml2enc, an error of "AH01425: I18n support in mod_proxy_html requires mod_xml2enc. Without it, non-ASCII character in proxied pages are likely to display incorrectly". If anyone thinks it warrants it, I'll open a seperate bug for adding that dependency. I also volunteer to be a proxy maintainer for this package if Matthew Smith is not able to or interested in doing so.
Matthew Smith has not replied in the aff after circa 3 weeks. Russell Knighton, would you be interested in proxy maintaining the package? You can peruse https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers at you leisure. You may join in the irc channel if you wish to discuss it 'live', as it were.
I am facing the same problem here. Thanks a lot for the config file! Looks like it is working. At least I do not see the apache startup warning. Would be great if you would be the new maintainer for this, Russell!
(In reply to Ian Delaney from comment #3) > Matthew Smith has not replied in the aff after circa 3 weeks. > Russell Knighton, would you be interested in proxy maintaining the package? Russell Knighton has not replied in the aff after circa 6 weeks
Sorry, this one slipped under my radar. Definitely wish to become proxy maintainer for this package. Do you need me to email the maintainers-needed address? Or can you set it up right from here?
Hi Russell! Thanks for offering to maintain this. You don't need to send an email anywhere - we can assign maintainership through this bug - though I will ask if you have looked through the information on the Proxy Maintainers Project page on the wiki[0]. Basically, you will be responsible for version bumps and bugs for this package. In terms of this bug (specifically comment 2) are there any changes required to attachment 426268 [details] to address this? Or should this be notified with an `elog` entry in the ebuild? Can you prepare an ebuild for this and attach? You can get assistance if required by asking either here, in an email to the Proxy Maintainers project, or in the #gentoo-proxy-maint or #gentoo-dev-help channels on the Freenode IRC network. The DevManual[1] is also a good reference to bookmark! And yes, the dependency issue should be addressed in a separate bug, though I'm still unsure if it's optional or not - the message indicates that it is optional but likely desired. Again, thanks for offering to maintain! [0] https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers [1] https://devmanual.gentoo.org/
Created attachment 432116 [details] mod_xml2enc-1.0.4.ebuild Version bump for mod_xml2enc to version 1.0.4 incorporating the following changes: * Added an EAPI * Changed SRC_URI to now save versions of the files (allowing for proper version bumps) * Added apache config module
Created attachment 432118 [details] 26_mod_xml2enc.conf Updated apache module config file
Hi Sam, > I will ask if you have looked through the information on the Proxy Maintainers Project page on the wiki I can confirm I have read this - I'm already proxy maintainer on another package and, time permiting, wish to take on many more. > are there any changes required to attachment 426268 [details] to address this? Yes there was, another line was needed - added and attached (though I couldn't obsolete the old version - presumably I could have if I'm the asignee for this bug?) > Can you prepare an ebuild for this and attach? Done. I've made a couple of more changes as well as actually version bump it to match the version in the source file from upstream. I realised that, because of the way the SRC_URI was downloading a pair of static files in 1.0.3, unless you removed that from your distfiles manually, you'd never get a real version bump (as well as potential manifest fails in the future). As a result, I've moved these too be versioned now - if you can think of a better wasy of doing this, then please let me know. > And yes, the dependency issue should be addressed in a separate bug, though I'm still unsure if it's optional or not - the message indicates that it is optional but likely desired. I think it is optional - without the xml2enc module proxy_html still works, it just give you that warning message. I'll file a new bug and propose that mod_xml2enc should be a dependency anyway. > Again, thanks for offering to maintain! My pleasure.
Thanks! You've done a good job, particularly with replacing the package name with variables, however there were still a few minor things that I fixed as I committed (rather than needing you to attach another version here) that I will list below - this is more for your information, hence all the references below. :) - Invalid header [0] The header for the ebuild was incorrect (had the wrong year). You can see an example of the header at ${PORTDIR}/header.txt - Undefined IUSE [1] If there are no USE flags defined, the IUSE variable doesn't need to be defined at all. - Incorrect KEYWORDS [2] When doing version bumps (or any significant change to an ebuild) any stable KEYWORDS should be changed to testing. - Missing "|| die" statements [3] Any calls to external utilities (as in, aren't portage helpers) like mkdir and cp should be called with "|| die" (even when using a --force option) as there can be circumstances where they fail (such as permission denied). Lastly, this could also have the EAPI bumped even further to EAPI6, but I've left it as-is for now since EAPI5 is still valid. For this ebuild there wouldn't be any additional changes, but some ebuilds would need further work if bumping to EAPI6 [4]. Otherwise, good work, and welcome to proxy maintainership! [0] https://devmanual.gentoo.org/ebuild-writing/file-format/#ebuild-header [1] https://devmanual.gentoo.org/ebuild-writing/variables/#iuse [2] https://devmanual.gentoo.org/keywording/#keywording-on-upgrades [3] https://devmanual.gentoo.org/ebuild-writing/error-handling/#the-die-function [4] https://projects.gentoo.org/pms/6/pms.html#x1-175000E
commit 33da93895c529ba8e8deb8dfd52f077c401d06ee Author: Sam Jorna <wraeth@gentoo.org> Date: Wed Apr 27 00:13:33 2016 +1000 www-apache/mod_xml2enc: bump to 1.0.4, add config Bumps to v1.0.4 as well as adds an apache modules.d config to enable. Original config file contributed by user Matthew Smith and updated by maintainer Russell Knighton along with version bump. Gentoo-bug: 575410 Package-Manager: portage-2.2.28 commit 8b366ab93960f2fe5e60f47d486c33266df50d85 Author: Sam Jorna <wraeth@gentoo.org> Date: Wed Apr 27 00:06:50 2016 +1000 www-apache/mod_xml2enc: assign proxy maintainer Proxy maintainer assigned from bug 575410. Gentoo-bug: 575410 Package-Manager: portage-2.2.28
(In reply to Sam Jorna (wraeth) from comment #11) > Otherwise, good work, and welcome to proxy maintainership! In my defence, I didn't realise you already had maintainership of x11-terms/roxterm. :D
> In my defence, I didn't realise you already had maintainership of x11-terms/roxterm. :D No worries - I'm going to try and take them on as I come across them. Might tackle a few more apache modules... Thanks for all the tips - I should have caught some of those, especially the header date one. I'll make sure I read further documentation. For posterity, noting here that I filed bug 581268 for the possible dependency issue.
(In reply to Russell Knighton from comment #14) > Thanks for all the tips - I should have caught some of those, especially the > header date one. I'll make sure I read further documentation. If you're not familiar with it, the `repoman` utility (installed with portage itself) performs various QA checks (as well as generating manifests and preformatting commit messages). Just make your changes and run `repoman full` from within the ebuild directory (not from a category or top-level directory, as it will then go and check all packages under it).
> If you're not familiar with it, the `repoman` utility ... Nope, wasn't familiar with that one - thanks again. I'll make sure I investigate that one. It'll be very useful...
Just so you're aware, it was pointed out to me that I also missed an implicit system dependency [0], which I've corrected in commit 54e8e3f4 [1]. [0] https://devmanual.gentoo.org/general-concepts/dependencies/#implicit-system-dependency [1] https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=54e8e3f46abe989b9bf7f7150f60014267447bb8
Okay, thanks for the update. I did see that, and wondered if it was truly required... I guess it wasn't. Cheers,
