`USE='nls' emerge sys-apps/net-tools` does not add '-lintl' to when linking. I considered patching just the ebuild to manipulate LIBS, but the net-tools Makefile does not support the LIBS environment variable. This is blocking bug 574794. Patch to follow.
Created attachment 425864 [details, diff] Patch for sys-apps/net-tools ebuild to support '-lintl' when USE='nls'
Comment on attachment 425864 [details, diff] Patch for sys-apps/net-tools ebuild to support '-lintl' when USE='nls' You're putting $(LIBS) in the wrong place; it should go after any object files on the command line. Also, I don't think libintl is used on glibc systems; I have never run into a build failure on my vanilla Gentoo system.
> You're putting $(LIBS) in the wrong place; it should go after any object > files on the command line. Thanks for catching that. I will update appropriately. > Also, I don't think libintl is used on glibc systems; I have never run into > a build failure on my vanilla Gentoo system. Is there a mechanism to determine whether glibc is provided or not to make the patching conditional? I'm still getting familiar with gentoo myself and ebuilds and would like to learn the proper way to do this (and to contribute).
you should just send patches upstream and i'll review/merge them there
