Attatched nethack-3.3.1.tar.gz Includes: nethack-3.3.1.ebuild files/README.gentoo (A quick readme about how it was configured in the ebuild and general information for the user not included with the standard source) files/TODO (Future plans for this ebuild) files/digest-nethack-3.3.1 files/nethack-3.3.1-X11.diff (Patch for X11 configuration) files/nethack-3.3.1-gentoo.diff (Patch for complications do to ${D}) files/nethack-3.3.1-gnome.diff (Patch to use gnome-config instead of full paths) files/nethack-3.3.1-gzip.diff (Patch to use gnu gzip) files/nethack-3.3.1-ncurses.diff (Patch to use ncurses) files/nethackrc (sample nethackrc) nethack is a classic roguelike game (www.nethack.org) nethack doesn't use GNU autoconf/automake which complicates the build process slightly. Also, the many patches exist because some must be applied at different stages of the build process. Currently optional gnome support compiles and produces valid code, but attention must be made to the setgid games nature of nethack. Optional Qt support exists in nethack source but is compiled out of the ebuild until I can get it to work properly. suggested placement: app-games/nethack This is my first ebuild, all feedback - good or bad - desired. Bob
Created attachment 135 [details] nethack-3.3.1
This looks like really painful app to package -- thanks for tackling it. I created a ChangeLog and moved your author credit line to there. The verbose comments are very good, especially for an unusual package like this. If parallel make (emake) doesn't work for a package, it is helpful to have a comment, so that there is not doubt that it's not just a typo or a copy-and-paste error. I see you used both patches and sed scripts to fix things and set compile options. I personally do all I can to avoid diff-based patches, but your solutions seem entirely acceptable. I did consolidate a few of your sed scripts. There are several 'do' commands in /usr/lib/portage/bin that can be useful, especially in the 'install' section. I replaced a few of the install lines with a 'dodoc' call. I asked around about putting this in /usr/games, and so now we have a new gentoo policy to avoid that. ;-) I've tried to move everything, but I'm not sure it's working yet. Source patching should be done in unpack instead of compile. As a general rule, the compile step should be repeatable, and patches (and usually sed scripts, too) are NOT repeatable. I'm not going to mess with it at this point, since that's a minor gripe, but keep it in mind for the future. I had to set CFLAGS specifically on the make command-line in order for the settings in /etc/make.conf to take effect. Unfortunately, this also overrides settings applied by patch into the Makefile that we actually need, so I had to duplicate these in the ebuild. Well, I'm still not comfortable checking this in quite yet. I think it's close, but it needs a bit more testing and some polish. If you want to see what I've done so far, critisize my changes, or make changes of your own, just send me email. ;-) --Chouser
nethack 3.4.0 is in portage, so this bug seems to be obsolete. can be closed.
