Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 574966 - epatch_user should strip subslot from /etc/portage/patches/$CAT/$PN:$SLOT
Summary: epatch_user should strip subslot from /etc/portage/patches/$CAT/$PN:$SLOT
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-17 14:02 UTC by Alexis Ballier
Modified: 2016-02-17 22:08 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Ballier gentoo-dev 2016-02-17 14:02:32 UTC 
eapply_user in portage does:
  for d in "${basedir}"/${CATEGORY}/{${P}-${PR},${P},${PN}}{,:${SLOT%/*}}; do

epatch_user does:
  for check in ${CATEGORY}/{${P}-${PR},${P},${PN}}{,:${SLOT}}; do


I think portage using ${SLOT%/*} is more correct
Comment 1 Alexis Ballier gentoo-dev 2016-02-17 21:12:23 UTC 
commit 5a08a63420601a47075da957e25dbc909ce33aef
Author: Alexis Ballier <aballier@gentoo.org>
Date:   Wed Feb 17 22:07:59 2016 +0100

    eclass/eutils.eclass: epatch_user: Strip subslot when taking patches from  /etc/portage/patches/$CAT/$PN:$SLOT. Bug #574966.
    
    This makes it similar to what portage does with eapply_user.




it was so trivial, and epatch_user being more or less deprecated, that i took the liberty to change it (i dont think $SLOT containing slashes can even work)
Comment 2 SpanKY gentoo-dev 2016-02-17 22:08:58 UTC 
seems fine:
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5a08a63420601a47075da957e25dbc909ce33aef

as long as the SLOT only has one / that'll work fine.  thanks!