574398 – media-gfx/xv-3.10a-r18 doesn't grok common file formats

Bug 574398 - media-gfx/xv-3.10a-r18 doesn't grok common file formats

Summary: media-gfx/xv-3.10a-r18 doesn't grok common file formats

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2016-02-11 06:37 UTC by Norman Yarvin
Modified:	2016-02-14 12:20 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Fixed ebuild for xv (xv-3.10a-r18.ebuild,2.40 KB, text/plain) 2016-02-11 06:37 UTC, Norman Yarvin	Details
Corrected fix (xv-3.10a-r18.ebuild.patch,379 bytes, patch) 2016-02-12 15:15 UTC, Andrew Church	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Norman Yarvin 2016-02-11 06:37:52 UTC

Created attachment 425182 [details]
Fixed ebuild for xv

Since updating to -r18, xv won't open jpg or png files, at least not as images.  The problem is that the -r18 ebuild uses "append-cppflags" to enable jpg and png where it should use "append-cflags".  (This is a C program, not a C++ one!)  Fixed ebuild attached.

Comment 1 Andrew Church 2016-02-12 15:15:59 UTC

Created attachment 425330 [details, diff]
Corrected fix

CPPFLAGS normally means "preprocessor flags" (CXXFLAGS is for the C++ compiler) so I think append-cppflags is correct.  The problem is that the make command line doesn't include ${CPPFLAGS}, only ${CFLAGS}.  Patch attached to make that addition.

Comment 2 Ulrich Müller gentoo-dev

2016-02-14 12:20:38 UTC

(In reply to Andrew Church from comment #1)
> Created attachment 425330 [details, diff] [details, diff]
> Corrected fix

Thanks, fixed in -r19.