Version bump to q4wine-1.2-r2. I have added qt5 flag, so now it will be possible to build q4wine with qt5 libraries. Reproducible: Always
Created attachment 424534 [details] version bump with qt5 support
Upstream version 1.2-r2 is already packaged in gentoo (as 1.2_p2 to avoid conflicts with gentoo-specific revision numbers). This bug is requesting qt5 support in that (or a future) version.
It fails to build for me: CMake Error at src/q4wine-lib/CMakeLists.txt:74 (QT5_WRAP_UI): Unknown CMake command "QT5_WRAP_UI". It also appears to try to detect qt4 unconditionally.
Hi, Michael Can you add some more info please? 1. full build log. 2. cmake version. 3. cmake use flags. thanks.
Created attachment 425276 [details] build log [ebuild R ~] dev-util/cmake-3.4.3::gentoo USE="ncurses -doc -emacs -qt4 -qt5 -system-jsoncpp {-test}" 0 KiB
Hi, Michael Here you are my build log: http://pastebin.com/rA3YGvAZ on my gentoo box: http://pastebin.com/dgmUmg8U (emerge --info) The only difference, is how QT5 cmake option is set by portage: From your log: -- QT5 : yes From my log: -- QT5 : ON It seems like in your case portage function $(cmake-utils_use qt5) does set the option to wrong value. According to https://cmake.org/cmake/help/v3.4/command/option.html the valid values should be "ON" or "OFF", not "yes". This is why cmake fails to detect Qt5 libs and defaults to Qt4.
(In reply to John Brezerk from comment #6) > Hi, Michael > > Here you are my build log: http://pastebin.com/rA3YGvAZ on my gentoo box: > http://pastebin.com/dgmUmg8U (emerge --info) > > The only difference, is how QT5 cmake option is set by portage: > > From your log: > -- QT5 : yes > From my log: > -- QT5 : ON > > It seems like in your case portage function $(cmake-utils_use qt5) does set > the option to wrong value. According to > https://cmake.org/cmake/help/v3.4/command/option.html the valid values > should be "ON" or "OFF", not "yes". > > This is why cmake fails to detect Qt5 libs and defaults to Qt4. Normally on/yes/true are interchangeable, but for some reason this package does stuff like if(QT5 MATCHES ON) instead of just if(QT5) in some places. Anyway, thanks, patch pushed with some minor changes. https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b5044478a38f2af48dbdbd708d5069b72133f141
