Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 573728 - sci-mathematics/rw - please add x86 keyword
Summary: sci-mathematics/rw - please add x86 keyword
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Keywording and Stabilization (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michael Orlitzky
URL:
Whiteboard:
Keywords: KEYWORDREQ
Depends on:
Blocks:
 
Reported: 2016-02-03 01:59 UTC by Alessandro Barbieri
Modified: 2016-06-03 13:28 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alessandro Barbieri 2016-02-03 01:59:34 UTC
As suggested by sage-on-gento staff can you keyword that package?

https://github.com/cschwan/sage-on-gentoo/issues/393#issuecomment-178937353
Comment 1 Tomáš Mózes 2016-02-03 20:05:09 UTC
Alessandro, have you tested this on x86?
Comment 2 François Bissey 2016-02-03 20:15:41 UTC
Alessandro I think Tomáš wants to know if you run the test. If not, can you just run 
ebuild /usr/portage/sci-mathematics/rw-0.7.ebuild test 

If it doesn't report anything wrong it is all OK.
Comment 3 François Bissey 2016-02-03 20:26:35 UTC
That should have been
ebuild /usr/portage/sci-mathematics/rw/rw-0.7.ebuild test 
You should be able to do that as a regular user too. I just had a look and sadly there is no test so just installing will do.
Since you have sage installed you can sort of test it through
sage -t --long /usr/lib/python2.7/site-packages/sage/graphs/graph_decompositions/rankwidth.pyx
Comment 4 Tomáš Mózes 2016-02-04 06:20:44 UTC
Under tested I meant whatever from trying to compile it on x86 and trying some code with it or running tests (if any). Since this was not enabled on x86, maybe there is a reason for it. So this is just to provide some evidence that, yes, it works fine on x86.
Comment 5 François Bissey 2016-02-04 07:14:37 UTC
The person that committed it, just had an amd64 machine and just left it at that. There is no reason this wouldn't work on x86 and it can be given a workout from sage.
Comment 6 Michael Orlitzky gentoo-dev 2016-02-04 16:08:51 UTC
(In reply to Francois Bissey from comment #5)
> The person that committed it, just had an amd64 machine and just left it at
> that. There is no reason this wouldn't work on x86 and it can be given a
> workout from sage.

I didn't want to commit it ~x86 without actually trying it, but all indications are that it works fine. There are some example graphs you can test if you build the executable. @x86, please keyword if it builds and this example works:

$ rw --edgelist /usr/share/doc/rw-0.7/grid 
9 vertices.
Calculating for subsets of size 0.
Calculating for subsets of size 1.
Calculating for subsets of size 2.
Calculating for subsets of size 3.
Calculating for subsets of size 4.
Calculating for subsets of size 5.
Calculating for subsets of size 6.
Calculating for subsets of size 7.
Calculating for subsets of size 8.
Calculating for subsets of size 9.
rank-width: 2
cslot: 1ff
	cslot: 1
	cslot: 1fe
		cslot: 2
		cslot: 1fc
			cslot: 8
			cslot: 1f4
				cslot: 54
					cslot: 4
					cslot: 50
						cslot: 10
						cslot: 40
				cslot: 1a0
					cslot: 20
					cslot: 180
						cslot: 80
						cslot: 100
Comment 7 Alessandro Barbieri 2016-02-04 19:38:58 UTC
(In reply to Michael Orlitzky from comment #6)
> (In reply to Francois Bissey from comment #5)
> > The person that committed it, just had an amd64 machine and just left it at
> > that. There is no reason this wouldn't work on x86 and it can be given a
> > workout from sage.
> 
> I didn't want to commit it ~x86 without actually trying it, but all
> indications are that it works fine. There are some example graphs you can
> test if you build the executable. @x86, please keyword if it builds and this
> example works:
> 
> $ rw --edgelist /usr/share/doc/rw-0.7/grid 
> 9 vertices.
> Calculating for subsets of size 0.
> Calculating for subsets of size 1.
> Calculating for subsets of size 2.
> Calculating for subsets of size 3.
> Calculating for subsets of size 4.
> Calculating for subsets of size 5.
> Calculating for subsets of size 6.
> Calculating for subsets of size 7.
> Calculating for subsets of size 8.
> Calculating for subsets of size 9.
> rank-width: 2
> cslot: 1ff
> 	cslot: 1
> 	cslot: 1fe
> 		cslot: 2
> 		cslot: 1fc
> 			cslot: 8
> 			cslot: 1f4
> 				cslot: 54
> 					cslot: 4
> 					cslot: 50
> 						cslot: 10
> 						cslot: 40
> 				cslot: 1a0
> 					cslot: 20
> 					cslot: 180
> 						cslot: 80
> 						cslot: 100

I get:

rw --edgelist /usr/share/doc/rw-0.7/grid
9 vertices.
Calculating for subsets of size 0.
Calculating for subsets of size 1.
Calculating for subsets of size 2.
Calculating for subsets of size 3.
Calculating for subsets of size 4.
Calculating for subsets of size 5.
Calculating for subsets of size 6.
Calculating for subsets of size 7.
Calculating for subsets of size 8.
Calculating for subsets of size 9.
rank-width: 2
cslot: 1ff
        cslot: 1
        cslot: 1fe
                cslot: 2
                cslot: 1fc
                        cslot: 8
                        cslot: 1f4
                                cslot: 54
                                        cslot: 4
                                        cslot: 50
                                                cslot: 10
                                                cslot: 40
                                cslot: 1a0
                                        cslot: 20
                                        cslot: 180
                                                cslot: 80
                                                cslot: 100
Comment 8 Alessandro Barbieri 2016-02-04 19:40:48 UTC
(In reply to Francois Bissey from comment #3)
> That should have been
> ebuild /usr/portage/sci-mathematics/rw/rw-0.7.ebuild test 
> You should be able to do that as a regular user too. I just had a look and
> sadly there is no test so just installing will do.
> Since you have sage installed you can sort of test it through
> sage -t --long
> /usr/lib/python2.7/site-packages/sage/graphs/graph_decompositions/rankwidth.
> pyx

The first command ends in:

>>> Source compiled.
>>> Test phase: sci-mathematics/rw-0.7
>>> Working in BUILD_DIR: "/var/tmp/portage/sci-mathematics/rw-0.7/work/rw-0.7"
make -j1 check 
make: Nothing to be done for 'check'.
>>> Completed testing sci-mathematics/rw-0.7

the second doesn't work 

sage -t --long /usr/lib/python2.7/site-packages/sage/graphs/graph_decompositions/rankwidth.pyx                                
/usr/bin/sage: riga 539: exec: sage-runtests: non trovata
Comment 9 François Bissey 2016-02-04 21:23:04 UTC
(In reply to Alessandro Barbieri from comment #8)
> (In reply to Francois Bissey from comment #3)
> > That should have been
> > ebuild /usr/portage/sci-mathematics/rw/rw-0.7.ebuild test 
> > You should be able to do that as a regular user too. I just had a look and
> > sadly there is no test so just installing will do.
> > Since you have sage installed you can sort of test it through
> > sage -t --long
> > /usr/lib/python2.7/site-packages/sage/graphs/graph_decompositions/rankwidth.
> > pyx
> 
> The first command ends in:
> 
> >>> Source compiled.
> >>> Test phase: sci-mathematics/rw-0.7
> >>> Working in BUILD_DIR: "/var/tmp/portage/sci-mathematics/rw-0.7/work/rw-0.7"
> make -j1 check 
> make: Nothing to be done for 'check'.
> >>> Completed testing sci-mathematics/rw-0.7
> 
> the second doesn't work 
> 
> sage -t --long
> /usr/lib/python2.7/site-packages/sage/graphs/graph_decompositions/rankwidth.
> pyx                                
> /usr/bin/sage: riga 539: exec: sage-runtests: non trovata

Silly me! It cannot work if you didn't install sage with the "testsuite" useflag. But you should be able to run Michael's test.
Comment 10 Alessandro Barbieri 2016-02-17 02:01:08 UTC
(In reply to Francois Bissey from comment #3)
> That should have been
> ebuild /usr/portage/sci-mathematics/rw/rw-0.7.ebuild test 
> You should be able to do that as a regular user too. I just had a look and
> sadly there is no test so just installing will do.
> Since you have sage installed you can sort of test it through
> sage -t --long
> /usr/lib/python2.7/site-packages/sage/graphs/graph_decompositions/rankwidth.
> pyx

Seems to pass the test.

sage -t --long /usr/lib/python2.7/site-packages/sage/graphs/graph_decompositions/rankwidth.pyx
too many failed tests, not using stored timings
Running doctests with ID 2016-02-17-02-59-11-fc7fa697.
Using --optional=optional,sage
Doctesting 1 file.
sage -t --long /usr/lib/python2.7/site-packages/sage/graphs/graph_decompositions/rankwidth.pyx
    [23 tests, 0.51 s]
----------------------------------------------------------------------
All tests passed!
----------------------------------------------------------------------
Total time for all tests: 0.7 seconds
    cpu time: 0.2 seconds
    cumulative wall time: 0.5 seconds
Comment 11 Michael Orlitzky gentoo-dev 2016-06-03 13:28:32 UTC
I added the keyword after taking care of igraph (which was maintainer-needed):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3ce952baca9125fa4286ae17519a974fd82ac8fc