Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 573598 - games-roguelike/nethack - monocolored gameboard in the x11 port
Summary: games-roguelike/nethack - monocolored gameboard in the x11 port
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mira Ressel
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-01 15:37 UTC by mail
Modified: 2016-02-13 04:32 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info =games-roguelike/nethack-3.6.0-r1 > emerge.info (emerge.info,6.42 KB, application/x-info)
2016-02-01 15:37 UTC, mail
Details
patch winmap.c (patch-winmap,453 bytes, patch)
2016-02-09 10:13 UTC, mail
Details | Diff
patch that fixes color AND hilite_pile (winmap-patch,405 bytes, patch)
2016-02-09 20:40 UTC, mail
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mail 2016-02-01 15:37:56 UTC
Created attachment 424414 [details]
emerge --info =games-roguelike/nethack-3.6.0-r1 > emerge.info

Hello,

I installed the x11 port of nethack-3.6.0 and I'm using the non-tiled version.
Although the gui is colored and I can change the gui colors by editing the /etc/X11/app-defaults/NetHack file, the ascii gameboard keeps monochrome. Only the NetHack*map*background and NetHack*map*foreground have an effect of gameboard colors. Of course I have enabled the color option in my .nethackrc and also checked it ingame via shift-O.
I've emigrated from archlinux so I don't know if the color option worked in previous package versions.
Comment 1 Mira Ressel 2016-02-01 19:01:34 UTC
I'll have a look.

I've basically rewritten the whole ebuild from scratch for version 3.6.0, so it'd be interesting if 3.4.3 has the same problems. The 3.4.3 ebuild are still in the tree (luckily -- I was going to remove them next weekend), so trying it is simply a matter of "emerge ~games-roguelike/nethack-3.4.3".
Comment 2 mail 2016-02-01 21:22:08 UTC
(In reply to Luis Ressel from comment #1)
> I'll have a look.
> 
> I've basically rewritten the whole ebuild from scratch for version 3.6.0, so
> it'd be interesting if 3.4.3 has the same problems. The 3.4.3 ebuild are
> still in the tree (luckily -- I was going to remove them next weekend), so
> trying it is simply a matter of "emerge ~games-roguelike/nethack-3.4.3".

The 3.4.3 x11 build seems to ignore the !tiled_map option.
Comment 3 mail 2016-02-03 15:21:52 UTC
nor does the 3.4.3 build support the ascii_map option.
Comment 4 Mira Ressel 2016-02-04 23:24:12 UTC
I've confirmed the issue. Nethack's non-tiled X11 mode refuses to colorize the dungeon on my box, too.

I haven't found out how to fix it yet. The issue seems quite weird; nethack's other x11 windows are colorized fine, after all. Perhaps it's an upstream bug? I'll have another look this weekend.
Comment 5 Mira Ressel 2016-02-07 15:18:18 UTC
I've dug through the relevant code, but I couldn't find out what causes this. It's an upstream regression; everything worked fine in 3.4.3.

I'll report this bug to upstream tomorrow. Until it's fixed, I'd recommend to use the tty interface; it's much better supported both by upstream and me, and the non-tiled x11 interface doesn't offer many advantages over the tty interface anyway.
Comment 6 Mira Ressel 2016-02-07 20:23:09 UTC
Reported to upstream. Unfortunately they use a contact form for bug reports, not a public bugtracker. I'll update this bug if I get an answer from them.
Comment 7 mail 2016-02-09 10:13:34 UTC
Created attachment 425022 [details, diff]
patch winmap.c
Comment 8 mail 2016-02-09 20:40:25 UTC
Created attachment 425088 [details, diff]
patch that fixes color AND hilite_pile
Comment 9 Mira Ressel 2016-02-12 15:24:51 UTC
Thanks for your patches! Upstream has also fixed the issue in the meantime, so I'll apply their patch instead.

I've submitted the updated games-roguelike/nethack-3.6.0-r3 ebuild to the proxy-maint team (https://github.com/gentoo/gentoo/pull/842). They're usually quite fast, so it'll probably get merged into the gentoo tree soon.
Comment 10 Ian Delaney (RETIRED) gentoo-dev 2016-02-13 04:32:36 UTC
commit 69f0831c1243d1b889f38a2d5261420664ee59c9
Author: Luis Ressel <aranea@aixah.de>
Date:   Fri Feb 12 15:50:47 2016 +0100

    games-roguelike/nethack: Fix map colors in x11 interface
    
    Gentoo-Bug: 573598