Bug 573362 – media-gfx/graphite2 uses private API from cmake-utils (_cmake_check_build_dir)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Michael Palimaka (kensington) 2016-01-30 08:15:45 UTC]

The ebuild calls _cmake_check_build_dir, but that's a private function that shouldn't be called from ebuilds.

[Comment 1 Andreas K. Hüttel 2016-02-29 12:56:00 UTC]

(In reply to Michael Palimaka (kensington) from comment #0)
> The ebuild calls _cmake_check_build_dir, but that's a private function that
> shouldn't be called from ebuilds.

multilib_src_configure() {
        local mycmakeargs=(
                "-DVM_MACHINE_TYPE=direct"
                # http://sourceforge.net/p/silgraphite/bugs/49/
                $([[ ${CHOST} == powerpc*-apple* ]] && \
                        echo "-DGRAPHITE2_NSEGCACHE:BOOL=ON")
        )

        cmake-utils_src_configure

        # fix perl linking
        if multilib_is_native_abi && use perl; then
                _cmake_check_build_dir init
                sed -i \
                        -e "s:@BUILD_DIR@:\"${BUILD_DIR}/src\":" \
                        "${S}"/contrib/perl/Build.PL || die
        fi
}

Question... 
1) _cmake_check_build_dir is already called inside cmake-utils_src_configure
2) I see nothing inside _cmake_check_build_dir that uses it's argument

Doesnt this mean the call can just be removed here?

[Comment 2 Andreas K. Hüttel 2016-02-29 13:00:25 UTC]

commit 3a89dfb3e1c516626eecd8c845984c215afa6793
Author: Andreas K. Hüttel <[e-mail]>
Date:   Mon Feb 29 13:59:16 2016 +0100

    media-gfx/graphite2: Remove the call to _cmake_check_build_dir, bug 573362
    
    Package-Manager: portage-2.2.27

 media-gfx/graphite2/graphite2-1.3.5-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



Indeed works fine without it.