Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 573206 - app-editors/suplemon: a modern, powerful and intuitive console text editor with multi cursor support
Summary: app-editors/suplemon: a modern, powerful and intuitive console text editor wi...
Status: IN_PROGRESS
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Default Assignee for New Packages
URL:
Whiteboard:
Keywords:
Depends on: 573508
Blocks:
  Show dependency tree
 
Reported: 2016-01-28 14:11 UTC by Erik Quaeghebeur
Modified: 2016-06-27 05:34 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild (suplemon-0.1.44.ebuild,723 bytes, text/plain)
2016-01-29 12:40 UTC, Erik Quaeghebeur
Details
metadata (metadata.xml,993 bytes, text/xml)
2016-01-29 12:41 UTC, Erik Quaeghebeur
Details
ebuild (suplemon-0.1.44-r1.ebuild,734 bytes, text/plain)
2016-01-31 16:25 UTC, Erik Quaeghebeur
Details
metadata (metadata.xml,906 bytes, text/xml)
2016-01-31 16:25 UTC, Erik Quaeghebeur
Details
ebuild (suplemon-0.1.44-r1.ebuild,732 bytes, text/plain)
2016-01-31 21:11 UTC, Erik Quaeghebeur
Details
metadata (metadata.xml,1005 bytes, text/xml)
2016-04-03 13:01 UTC, Erik Quaeghebeur
Details
ebuild (suplemon-0.1.51.ebuild,830 bytes, text/plain)
2016-04-03 13:03 UTC, Erik Quaeghebeur
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Quaeghebeur 2016-01-28 14:11:53 UTC
This is a request to add an ebuild for suplemon in portage.

Suplemon is a modern, powerful and intuitive console text editor with multi cursor support. Suplemon replicates Sublime Text style functionality in the terminal with the ease of use of Nano.

Python 3.3+.

https://github.com/richrd/suplemon
Comment 1 Tomáš Mózes 2016-01-28 19:41:54 UTC
Hello Erik, can you provide an ebuild for it and maintain it?
Comment 2 Erik Quaeghebeur 2016-01-29 12:40:34 UTC
Created attachment 424152 [details]
ebuild
Comment 3 Erik Quaeghebeur 2016-01-29 12:41:03 UTC
Created attachment 424154 [details]
metadata
Comment 4 Erik Quaeghebeur 2016-01-29 12:45:20 UTC
(In reply to Tomáš Mózes from comment #1)
> Hello Erik, can you provide an ebuild for it and maintain it?

Yes, I think I can. Please find a proposed ebuild and the accompanying metadata attached. It works as expected on my setup.

Some questions & remarks:

* Only ~amd64, because I cannot check other setups.

* No use flag is on by default; what are the criteria to decide whether to do this or not?

* PYTHON_COMPAT: only checked CPython 3.4, but also listed 3.3 and 3.5

* Improvement suggestions appreciated.
Comment 5 Tomáš Mózes 2016-01-30 12:34:26 UTC
Fine basic ebuild, thanks for it.

A few notes:
- we can use EAPI=6
- I would include python 2.7 in PYTHON_COMPAT as it's very popular and my quick test showed that suplemon is working with it
- I would remove python 3.3 from PYTHON_COMPAT as it's going to fade away
- the DESCRIPTION is too long, if you run repoman it will shout. Besides the package name usually does not appear in the description itself, maybe a simple "Console text editor with multi cursor support" will suffice?
- you can add ~x86 as it should work fine
- is this code needed?

python_install_all() {
	distutils-r1_python_install_all
}
- I would introduce and ebuild for flake8-quotes
- when depending on python stuff, add PYTHON_USEDEP, else it might not work when different packages are merged with different python targets
- I would depend unconditionally on flake8 (>=2.5.0 && < 3.0.0), flake8-quotes and pygments and make only xsel optional, common sense is applied

If you have any questions, feel free to ask, or any gentoo dev @proxy-maint on irc.
Comment 6 Tomáš Mózes 2016-01-31 06:32:55 UTC
And one more thing I forgot. In setup.py:
from setuptools import setup

So it is advisable to put dev-python/setuptools into DEPEND.
Comment 7 Erik Quaeghebeur 2016-01-31 16:24:27 UTC
(In reply to Tomáš Mózes from comment #5)
> - I would introduce and ebuild for flake8-quotes

See bug #573508
Comment 8 Erik Quaeghebeur 2016-01-31 16:25:21 UTC
Created attachment 424332 [details]
ebuild
Comment 9 Erik Quaeghebeur 2016-01-31 16:25:49 UTC
Created attachment 424334 [details]
metadata
Comment 10 Erik Quaeghebeur 2016-01-31 16:28:33 UTC
(In reply to Tomáš Mózes from comment #5)

I've revised the ebuild according to your suggestions. The only one I did not follow was

> - I would depend unconditionally on [...] flake8-quotes [...]

because flake8-quotes is a very opinionated linting extension and some people might not like it; currently, it cannot be configured from suplemon's configuration (see also https://github.com/richrd/suplemon/issues/113).
Comment 11 Tomáš Mózes 2016-01-31 19:19:18 UTC
@Erik, the ebuild looks fine to me.

Just cosmetic marks:
- sort KEYWORDS
- why not write DEPEND on one line?
Comment 12 Erik Quaeghebeur 2016-01-31 21:11:17 UTC
Created attachment 424366 [details]
ebuild
Comment 13 Tomáš Mózes 2016-02-01 06:54:23 UTC
Nice.
Comment 14 Erik Quaeghebeur 2016-04-03 13:01:00 UTC
Created attachment 429562 [details]
metadata

Update to GLEP67
Comment 15 Erik Quaeghebeur 2016-04-03 13:03:26 UTC
Created attachment 429564 [details]
ebuild

From discussion with the developer, it is clear that flake8-quotes is a development dependency. I've therefore removed it from the use flags and added it under the test feature (although no tests are run, so this may not be proper).

Also updated the download link format, which was changed upstream.
Comment 16 Ian Delaney (RETIRED) gentoo-dev 2016-04-11 07:07:42 UTC
The entry in metadata.xml  <name>Gentoo Python Project</name> (the full entry) need be taken out. The python project will accept no further packages. It can be added under g-p-m.

Once again you need the range of years in line 1, LICENSE MIT will suffice and the ebuild requires a version;  suplemon-0.1.51.ebuild

I am getting a failure of sorts in the test phase
Comment 17 Erik Quaeghebeur 2016-06-26 21:05:28 UTC
Given that I have not been able to find or create the time to complete the ebuild, I think adding it to the tree with me as proxy-maintainer would not be a good idea. I apologize to Tomáš and Ian, who have helped me get this far with this ebuild.

Please close or leave open for someone else to pick up as appropriate.

(In reply to Ian Delaney (RETIRED) from comment #16)
> LICENSE MIT will suffice

I looked at the license text included and even though the developers call it MIT, it is MIT-with-advertising, I think.
Comment 18 Tomáš Mózes 2016-06-27 05:34:34 UTC
Erik, I'll leave it open, feel free to finish your work later on.

Anyone else interested, your help is welcome.