Created attachment 423868 [details, diff] trojita-0.5-to-0.6.patch Hi, please bump Trojita to 0.6. There are some new l10n files in this release, and no need for a patch fixing the build failure on Qt 5.5 -- see the attached patch. As an addition, upstream now recommends the Qt5 builds (with Qt4 support being removed from git "soon"). If you could kill the Qt4 option from the -9999 ebuild, that would be nice.
Created attachment 423874 [details, diff] trojita-9999-updates.patch I took the opportunity to make some other changes at the same time. Please review.
(In reply to Michael Palimaka (kensington) from comment #1) > Created attachment 423874 [details, diff] [details, diff] > trojita-9999-updates.patch > > I took the opportunity to make some other changes at the same time. Please > review. Looks good. One minor thing: no need to quote 9999 inside [[ ]] Is the build system able to deal with a qtnetwork built without ssl support? if not, we need to add an [ssl] USE dep.
> Is the build system able to deal with a qtnetwork built without ssl support? > if not, we need to add an [ssl] USE dep. Support for TLS is required by the IMAP protocol, so please add that [ssl] dep. > + -DWITH_QT5=true This can be safely removed; it defaults to true and it's going away within a couple of days anyway. > +IUSE="debug dbus +password test +zlib" Could you please make the +dbus IUSE into an on-by-default? > + dev-qt/linguist-tools:5 This one could be theoretically made optional in case the user doesn't want to install any l10n files, but I don't think it's worth any effort here. BTW, there was some talk about not bothering with LINGUAS for stuff which only involves a `rm` call at the build time a couple of years ago. Do we want to ger rid of LINGUAS here, and always install all .po files? Oh, and thanks for these improvements :).
(In reply to Jan Kundrát from comment #3) > BTW, there was some talk about not bothering with LINGUAS for stuff which > only involves a `rm` call at the build time a couple of years ago. Do we > want to ger rid of LINGUAS here, and always install all .po files? There is no consensus, so that's your decision as primary maintainer. I don't personally find having the flag useful, and they're not in line with the trend of other per-file USE flags (logrotate, systemd, ...) being removed.
(In reply to Michael Palimaka (kensington) from comment #4) > There is no consensus, so that's your decision as primary maintainer. I > don't personally find having the flag useful, and they're not in line with > the trend of other per-file USE flags (logrotate, systemd, ...) being > removed. Fair enough, please kill them, then.
Thanks, fixed in git. I also added a fix to update the icon cache and ensure the correct version of linguist binaries are used in a qt4 build. https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fde5d3c7104d82d3db94b0335fea76cc9a65d3fc https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c04c058c778515b4757693f8371ebcf801b23772
