Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 57224 - agriffis borked libtool-1.5.2-r5 for mips/mips64/ppc64/uclibc
Summary: agriffis borked libtool-1.5.2-r5 for mips/mips64/ppc64/uclibc
Status: VERIFIED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: PPC64 All
: High normal (vote)
Assignee: ppc64 architecture team
URL:
Whiteboard:
Keywords:
: 57190 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-07-15 14:10 UTC by Brad House
Modified: 2004-07-15 21:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for libtool 1.5.2-r5 ebuild (libtool-1.5.2-r5.ebuild.patch,746 bytes, patch)
2004-07-15 14:11 UTC, Brad House
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brad House 2004-07-15 14:10:34 UTC
He tried to clean some stuff up ... here is a patch
that refixes the arches messed up, and finishes cleaning up
some stuff.

-Brad
Comment 1 Brad House 2004-07-15 14:11:36 UTC
Created attachment 35505 [details, diff]
patch for libtool 1.5.2-r5 ebuild
Comment 2 Tom Gall (RETIRED) gentoo-dev 2004-07-15 14:21:27 UTC
thanks brad, you've saved the day once again!
Comment 3 Tom Gall (RETIRED) gentoo-dev 2004-07-15 14:22:56 UTC
stick a fork in it
Comment 4 Aron Griffis (RETIRED) gentoo-dev 2004-07-15 21:03:25 UTC
:-(  Sorry about the breakage.

In truth, though, the invocations of gnuconfig_update in the libtool ebuilds were really screwed up.  It appears that somebody thought that gnuconfig_update depends on current working directory.  That's the only explanation I can think of for this kind of stuff in the ebuild:

   cd ${OLD_S}
   use mips && gnuconfig_update

   cd ${S}
   use mips && gnuconfig_update

What they didn't realize was that OLD_S was being fixed by an earlier invocation of gnuconfig_update which overrode S in src_unpack.  The later calls to gnuconfig_update were superfluous already because they were all happening in ${S}!

Recently I gave gnuconfig_update the ability to accept a starting directory as the first parameter.  So in this case I have changed the libtool ebuilds to call

   gnuconfig_update ${WORKDIR}

at the end of src_unpack (after all patches are applied so that the patches aren't broken).  This updates the gnuconfig stuff for all the source directories under ${WORKDIR}.  I've tested all the versions to make sure it's right.

So... my apologies for borking it!  :-(  On the other hand... it's a lot better now :-)  (and thanks Brad and Tom for catching the problem and putting in an initial fix)
Comment 5 Aron Griffis (RETIRED) gentoo-dev 2004-07-15 21:04:18 UTC
*** Bug 57190 has been marked as a duplicate of this bug. ***