Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 571744 - dev-python/mock-1.3.0-r1 installs broken symlink to changelog.txt (ChangeLog)
Summary: dev-python/mock-1.3.0-r1 installs broken symlink to changelog.txt (ChangeLog)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-13 13:23 UTC by Paul Healy
Modified: 2016-01-14 09:54 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
patch to install specific doc files including ChangeLog (mock-1.3.0.patch,285 bytes, patch)
2016-01-13 13:25 UTC, Paul Healy 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Healy 2016-01-13 13:23:43 UTC 
Merging dev-python/mock-1.3.0-r1 generates this QA Notice:
...
>>> /usr/share/doc/mock-1.3.0-r1/
>>> /usr/share/doc/mock-1.3.0-r1/index.txt.bz2
>>> /usr/share/doc/mock-1.3.0-r1/conf.py.bz2
 * QA Notice: Symbolic link /usr/share/doc/mock-1.3.0-r1/changelog.txt points to /usr/share/doc/ChangeLog which does not exist.
>>> /usr/share/doc/mock-1.3.0-r1/changelog.txt -> ../ChangeLog
>>> dev-python/mock-1.3.0-r1 merged.
...

The tarball contains:
/usr/portage/distfiles $ tar tvzf mock-1.3.0.tar.gz |grep -i change
lrwxrwxrwx robertc/robertc   0 2015-07-10 01:53 mock-1.3.0/docs/changelog.txt -> ../ChangeLog
-rw-rw-r-- robertc/robertc 38129 2015-07-24 00:17 mock-1.3.0/ChangeLog
/usr/portage/distfiles@ $ tar tvzf mock-1.3.0.tar.gz |grep -i docs
drwxrwxr-x robertc/robertc   0 2015-07-24 00:17 mock-1.3.0/docs/
lrwxrwxrwx robertc/robertc   0 2015-07-10 01:53 mock-1.3.0/docs/changelog.txt -> ../ChangeLog
-rw-rw-r-- robertc/robertc 5738 2015-07-23 20:51 mock-1.3.0/docs/index.txt
-rw-rw-r-- robertc/robertc 6297 2015-07-10 00:46 mock-1.3.0/docs/conf.py
/usr/portage/distfiles $

This one line patch to the ebuild installs specific doc files:

--- mock-1.3.0-r1.ebuild        2015-12-31 13:01:02.000000000 +0000
+++ mock-1.3.0-r2.ebuild        2016-01-13 13:11:23.065736948 +0000
@@ -37,6 +37,6 @@
 }
 
 python_install_all() {
-       local DOCS=( docs/. )
+       local DOCS=( docs/index.txt docs/conf.py ChangeLog )
        distutils-r1_python_install_all
 }


Reproducible: Always

Steps to Reproduce:
1.emerge -av =dev-python/mock-1.3.0-r1
2.
3.
Actual Results:  
 * QA Notice: Symbolic link /usr/share/doc/mock-1.3.0-r1/changelog.txt points to /usr/share/doc/ChangeLog which does not exist.

Expected Results:  
Install the actual ChangeLog.
Comment 1 Paul Healy 2016-01-13 13:25:22 UTC 
Created attachment 422770 [details, diff]
patch to install specific doc files including ChangeLog

Add proposed build patch.
Comment 2 Justin Lecher (RETIRED) gentoo-dev 2016-01-14 09:54:14 UTC 
commit 95bab145c37a568e38604686c060844c8761945c
Author: Justin Lecher <jlec@gentoo.org>
Date:   Thu Jan 14 09:59:12 2016 +0100

    dev-python/mock: Fix doc installation

    Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=571744

    Package-Manager: portage-2.2.26
    Signed-off-by: Justin Lecher <jlec@gentoo.org>

    https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=95bab145c37a568e38604686c060844c8761945c