Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 571616 - app-admin/logrotate fails test suite when /bin/sh is not bash
Summary: app-admin/logrotate fails test suite when /bin/sh is not bash
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Chema Alonso Josa (RETIRED)
URL: https://github.com/logrotate/logrotat...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-12 04:10 UTC by René Rhéaume
Modified: 2016-01-25 20:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
logrotate-3.9.1-nobashisms-in-test-r2.patch (logrotate-3.9.1-nobashisms-in-test-r2.patch,10.31 KB, patch)
2016-01-12 04:11 UTC, René Rhéaume
Details | Diff
logrotate-3.9.1-r1.ebuild.patch (logrotate-3.9.1-r1.ebuild.patch,479 bytes, patch)
2016-01-12 04:13 UTC, René Rhéaume
Details | Diff
logrotate-3.9.1-r1.ebuild.patch (logrotate-3.9.1-r1.ebuild.patch,479 bytes, patch)
2016-01-12 04:18 UTC, René Rhéaume
Details | Diff
emerge --info (emerge-info.txt,6.17 KB, text/plain)
2016-01-12 04:19 UTC, René Rhéaume
Details
build.log from emerge (build.log,6.09 KB, text/plain)
2016-01-12 04:23 UTC, René Rhéaume
Details

Note You need to log in before you can comment on or make changes to this bug.
Description René Rhéaume 2016-01-12 04:10:49 UTC
As written in the title, logrotate fails its test suite when /bin/sh points to a shell that is not bash (in my case, it's dash). However, there are bashisms in the test scripts and configuration and once we eliminate those bashisms, the test suite passes. 

Reproducible: Always

Steps to Reproduce:
1. FEATURES="test" emerge logrotate
2.
3.
Actual Results:  
emake failed (test phase)

Expected Results:  
logrotate installed on system
Comment 1 René Rhéaume 2016-01-12 04:11:47 UTC
Created attachment 422618 [details, diff]
logrotate-3.9.1-nobashisms-in-test-r2.patch
Comment 2 René Rhéaume 2016-01-12 04:13:59 UTC
Created attachment 422620 [details, diff]
logrotate-3.9.1-r1.ebuild.patch
Comment 3 René Rhéaume 2016-01-12 04:18:58 UTC
Created attachment 422622 [details, diff]
logrotate-3.9.1-r1.ebuild.patch
Comment 4 René Rhéaume 2016-01-12 04:19:43 UTC
Created attachment 422624 [details]
emerge --info
Comment 5 René Rhéaume 2016-01-12 04:23:39 UTC
Created attachment 422626 [details]
build.log from emerge
Comment 6 Chema Alonso Josa (RETIRED) gentoo-dev 2016-01-14 09:18:03 UTC
Thanks for the report and patches.

Upstream issue.submitted:

https://github.com/logrotate/logrotate/issues/15
Comment 7 Chema Alonso Josa (RETIRED) gentoo-dev 2016-01-25 20:00:57 UTC
Fixed in version 3.9.2:

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0cb2e1a56954a0ae8621953eb95584c999617e5d