Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 571366 - net-irc/znc: swig bump, license change, python simplification
Summary: net-irc/znc: swig bump, license change, python simplification
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Alex Alexander (RETIRED)
URL: https://github.com/gentoo/gentoo/pull...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-09 12:52 UTC by Alexey
Modified: 2016-03-21 14:22 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch (znc-gentoo.patch,860 bytes, patch)
2016-01-09 12:52 UTC, Alexey
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey 2016-01-09 12:52:20 UTC
Created attachment 422370 [details, diff]
Patch

1. ZNC 1.6 requires SWIG 3, because of C++11, compiler also should be new enough (4.7+ for GCC, 3.2+ for Clang), but I don't know how to express this requirement in ebuild

2. ZNC 1.2 switched license to Apache2, so this line applies to every .ebuild file, not only 1.6.1

3. ./configure --enable-python uses "python3" as default value anyway, no need to specify it explicitly; the option is for cases when python3.pc is not available (e.g. Gentoo outside of znc.ebuild)

I'm attaching patch for 1.6.1 ebuild.
Comment 1 Louis Sautier (sbraz) gentoo-dev 2016-03-19 17:19:07 UTC
Swig is actually not needed at all when building from a release, see http://wiki.znc.in/Modpython#Compiling and http://wiki.znc.in/Modperl#Compiling
Comment 2 Alexey 2016-03-19 19:58:43 UTC
That's true. However, with Gentoo's model of building software from source, I think it should ignore the prepackaged modperl/modpython files, because user can have /etc/portage/patches/net-irc/znc/... in place.
Comment 3 Louis Sautier (sbraz) gentoo-dev 2016-03-21 13:22:45 UTC
Hi, I've applied most of your changes in the version bump: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=942dfd926c80e680f564099f0b9535a2777c0245
I wasn't CCed to the bug so I didn't see your reply earlier. Do you need to patch the modpython/modperl code itself? Maybe it would be best to file a bug upstream if the shipped modules don't work for you.
I don't thing Gentoo's znc ever rebuilt them anyway, I just tried compiling znc 1.4 and configure yields:
swig:         not needed

I will now close this bug. If you want some changes made to the way the perl/python modules are built, I suggest you open a new bug.
Comment 4 Louis Sautier (sbraz) gentoo-dev 2016-03-21 13:26:00 UTC
OK, I just noticed you are actually part of the ZNC team, so I guess you don't have to file a bug if you want changes to the modules :)
I only applied the licence change to the latest ebuild, I will now do it for the others.