Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 571296 - dev-libs/libowfat-0.30 version bump
Summary: dev-libs/libowfat-0.30 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Patrick Lauer
URL: http://www.fefe.de/libowfat/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-08 17:08 UTC by Rolf Eike Beer
Modified: 2016-01-19 17:00 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rolf Eike Beer archtester 2016-01-08 17:08:23 UTC
The tarball is now compressed with xz instead of bz2, at a different URL, but otherwise it's the same.

However the ebuild can be cleaned up a bit, like I have done here: http://opensource.sf-tec.de/repos/dakon-overlay/dev-libs/libowfat/libowfat-0.30.ebuild

Reproducible: Always
Comment 1 Patrick Lauer gentoo-dev 2016-01-18 13:03:16 UTC
Why did you remove src_prepare ?

I'm not yet sure if there's any functional differences - no time to read the fine source.
Comment 2 Rolf Eike Beer archtester 2016-01-18 18:19:20 UTC
(In reply to Patrick Lauer from comment #1)
> Why did you remove src_prepare ?
> 
> I'm not yet sure if there's any functional differences - no time to read the
> fine source.

Because I just pass the flags as arguments to make in src_compile and src_install.
Comment 3 Patrick Lauer gentoo-dev 2016-01-19 09:32:01 UTC
Committed. There was a small typo in the DIET variable, which I fixed.

Thanks!
Comment 4 Rolf Eike Beer archtester 2016-01-19 17:00:12 UTC
Nope, which you introduced ;) The colon is the separator of the sed call from the previos src_prepare, so it doesn't actually belong there. Also I meanwhile noticed that a specific sed is no longer a build version, as the sed calls were only in src_prepare. Also it looks like an entry in Changelog is missing.