Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 571280 - app-admin/lastpass-4.0.0 version bump
Summary: app-admin/lastpass-4.0.0 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Göktürk Yüksek
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-08 14:11 UTC by Mike Nerone
Modified: 2016-04-22 16:47 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed patch (0001-app-admin-lastpass-version-bump-to-4.0.0-571280.patch,6.47 KB, patch)
2016-01-11 09:48 UTC, Göktürk Yüksek
Details | Diff
diff of the installation script (lastpass-script-3.2.16-vs-4.0.0.diff,1.90 KB, patch)
2016-03-24 04:03 UTC, Göktürk Yüksek
Details | Diff
Proposed patch (0001-app-admin-lastpass-bump-to-4.1.2.patch,5.90 KB, patch)
2016-03-24 09:53 UTC, Göktürk Yüksek
Details | Diff
Proposed patch (0001-app-admin-lastpass-bump-to-4.1.2.patch,6.11 KB, patch)
2016-03-26 05:33 UTC, Göktürk Yüksek
Details | Diff
Proposed solution, contains 2 commits (lastpass-binary-features-4.patch,6.17 KB, patch)
2016-04-05 23:10 UTC, Göktürk Yüksek
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Nerone 2016-01-08 14:11:56 UTC
Upstream bumped to app-admin/lastpass-4.0.0 on 2015-01-06. AFAICT, it's still functional with the 3.x binary component installed, but I didn't go out of my way to test the new features.

https://lastpass.com/upgrade.php
Comment 1 Göktürk Yüksek archtester gentoo-dev 2016-01-10 07:15:11 UTC
I checked their website when they first sent me the 4.0 announcement email and 4.0 for linux wasn't available for download. Looks like they fixed it now. I'll try to bump this tomorrow.
Comment 2 Göktürk Yüksek archtester gentoo-dev 2016-01-11 09:48:22 UTC
Created attachment 422540 [details, diff]
Proposed patch
Comment 3 Göktürk Yüksek archtester gentoo-dev 2016-01-12 03:04:44 UTC
Actually, the installer tarball installs version 3.2.42 of the extension for firefox. I retract the patch. This needs further investigation.
Comment 4 Göktürk Yüksek archtester gentoo-dev 2016-01-12 03:12:38 UTC
And to complicate the matters, they have version 4.0.0 for firefox and 4.0.2 for chromium.
Comment 5 Göktürk Yüksek archtester gentoo-dev 2016-01-12 04:20:00 UTC
(In reply to Gokturk Yuksek from comment #3)
> Actually, the installer tarball installs version 3.2.42 of the extension for
> firefox. I retract the patch. This needs further investigation.

This issue is reported upstream.
Comment 6 Göktürk Yüksek archtester gentoo-dev 2016-01-18 20:00:02 UTC
Upstream instructed me to download an xpi file. If lastpass for firefox can install itself without our help, I suggest that we drop firefox use flag. As far as I know, we don't usually keep firefox plugins in the tree. The exception was that some binary plugins needed to be installed so the plugins can utilize them properly.
Comment 7 Göktürk Yüksek archtester gentoo-dev 2016-01-24 21:37:14 UTC
I got a confirmation from the upstream that the universal installer will be updated for lastpass-4. I will bump this when that happens. If it doesn't happen within a week or two, I may consider dropping firefox until it's fixed so that chrom* users don't lag behind.
Comment 8 Göktürk Yüksek archtester gentoo-dev 2016-02-22 04:36:15 UTC
Bump. I just checked the upstream script and it still fetches the firefox plugin for lastpass 3.2.42.
Comment 9 Ian Delaney (RETIRED) gentoo-dev 2016-02-25 12:37:15 UTC
 Göktürk Yüksek I suggest you ping robbat2 over this for it has now become a farce. At least tell him if you'd like to have yourself withdrawn as the proxy maintainer.
Comment 10 Göktürk Yüksek archtester gentoo-dev 2016-02-26 07:41:49 UTC
(In reply to Ian Delaney from comment #9)
>  Göktürk Yüksek I suggest you ping robbat2 over this for it has now become a
> farce. At least tell him if you'd like to have yourself withdrawn as the
> proxy maintainer.

I didn't understand your comment. Can you clarify please? Thank you.
Comment 11 Göktürk Yüksek archtester gentoo-dev 2016-03-24 04:03:03 UTC
Created attachment 428886 [details, diff]
diff of the installation script

The upstream has responded:

"""
Hello,

Please retry now - the installer is now fetching version 4.0 for Firefox.

However, please note that due to changes in Firefox, pre-loaded extensions are disabled. As a result, we can no longer install the firefox plugin directly. Instead the installer script can only open the browser on the right page. I hope this is a minor inconvenience that's outweighed by having easier access to 4.0.
"""

Judging by the diff of the installation scripts, it does not actually download the xpi file for Firefox. Instead, it points to the website to download the add-on from. I will remove firefox USE flag from the ebuild.
Comment 12 Göktürk Yüksek archtester gentoo-dev 2016-03-24 09:53:54 UTC
Created attachment 428912 [details, diff]
Proposed patch
Comment 13 Göktürk Yüksek archtester gentoo-dev 2016-03-26 05:33:08 UTC
Created attachment 429026 [details, diff]
Proposed patch

Also created a PR with the same patch: https://github.com/gentoo/gentoo/pull/1139
Comment 14 Göktürk Yüksek archtester gentoo-dev 2016-03-26 06:49:43 UTC
@robbat, after dwfreed's suggestions on #gentoo-dev, I think it makes more sense to rename this package to app-admin/lastpss-binary-features (because that's what it does, it doesn't install the browser extension), remove IUSE (because all we install is one binary and two json files, shouldn't hurt too much to install them unconditionally) and remove RDEPEND (if we install unconditionally, we don't cause unnecessary rebuilds due to changed-use). What do you think?
Comment 15 Göktürk Yüksek archtester gentoo-dev 2016-04-05 23:10:24 UTC
Created attachment 429718 [details, diff]
Proposed solution, contains 2 commits

Per my discussion with robbat on #gentoo-dev, we have decided to introduce lastpass-4 as a new package: app-admin/lastpass-binary-features. The new package does not install the extension, only the binary components required by the extension. The ebuild shows the necessary URLs to download the extension in the install phase. We will keep app-admin/lastpass around until it's incompatible with the lastpass servers.

I've notified robbat about the patch on IRC already but attaching it here too for completeness. I'm not sure if the two commits can be squashed into one for better atomicity, I left as two.
Comment 16 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2016-04-06 16:54:41 UTC
goturk: looks good, if there's a PR with a single commit i'll cherry-pick that for merging...
Comment 17 Göktürk Yüksek archtester gentoo-dev 2016-04-06 18:32:20 UTC
https://github.com/gentoo/gentoo/pull/1209
Comment 18 Perfect Gentleman 2016-04-16 12:28:17 UTC
4.1.2 is out.
Comment 19 Göktürk Yüksek archtester gentoo-dev 2016-04-16 18:22:46 UTC
(In reply to Perfect Gentleman from comment #18)
> 4.1.2 is out.

4.1.2 is released as a result of our support ticket to get the installer fixed. The pull request on github will add 4.1.2 to the tree once merged.
Comment 20 Göktürk Yüksek archtester gentoo-dev 2016-04-22 16:47:23 UTC
Author:     Göktürk Yüksek <gokturk@binghamton.edu>
AuthorDate: Mon Apr 4 03:24:00 2016 -0400
Commit:     Robin H. Johnson <robbat2@gentoo.org>
CommitDate: Fri Apr 22 08:07:07 2016 -0700

    app-admin/lastpass-binary-component: new package #571280

    This is a split off from app-admin/lastpass and only installs the binary
    component required by the browser extension, as opposed to installing
    the extension too. Beginning with lastpass-4, the upstream only
    installs the binary component.

Please switch to app-admin/lastpass-binary-component. Note that Firefox users do not need to install any packages, they can just grab the extension from LastPass's website with binary features bundled.