Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 571002 - app-admin/mcelog-136 version bump
Summary: app-admin/mcelog-136 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Matt Turner
URL:
Whiteboard:
Keywords:
: 581476 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-01-05 15:59 UTC by Ben Kohler
Modified: 2017-03-08 02:07 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mcelog-129.ebuild (mcelog-129.ebuild,1.25 KB, text/plain)
2016-01-05 15:59 UTC, Ben Kohler
Details
mcelog-129-debugflags.patch (mcelog-129-debugflags.patch,377 bytes, patch)
2016-01-05 15:59 UTC, Ben Kohler
Details | Diff
mcelog-136.ebuild (mcelog-136.ebuild,1.25 KB, text/plain)
2016-04-28 20:42 UTC, Ben Kohler
Details
ebuild diff for 122 -> 136 (mcelog-ebuild.patch,938 bytes, patch)
2016-04-28 20:44 UTC, Ben Kohler
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Kohler gentoo-dev 2016-01-05 15:59:19 UTC
Created attachment 422020 [details]
mcelog-129.ebuild

mcelog has seen quite a few releases since our last one in portage, mostly just to support new cpus & hardware.  Though this recent commit requires an adjustment to one of our patches:
https://github.com/andikleen/mcelog/commit/b056a172dba6ba13c8badda1f897e98d70db581b

Since it now correctly uses $(CC) instead of gcc, our mcelog-1.0_pre3_p20120918-build.patch does more than it needs to.  I'm attaching a new patch, and a new 129 ebuild.  I have bumped the ebuild to EAPI6, hope that's ok.  I can revise the ebuild to stay on EAPI5 if there is any reason for that.

Thanks!
Comment 1 Ben Kohler gentoo-dev 2016-01-05 15:59:56 UTC
Created attachment 422022 [details, diff]
mcelog-129-debugflags.patch
Comment 2 Ben Kohler gentoo-dev 2016-04-28 20:42:02 UTC
Created attachment 432472 [details]
mcelog-136.ebuild

Here is my most recent ebuild for 136.  I bump these ebuilds in my overlay pretty promptly at https://github.com/benkohler/iamben-overlay/tree/master/app-admin/mcelog but yeah it's time we got a newer one in ::gentoo.

I will also attached a diff of this ebuild versus the latest in tree, let me know if you see any other changes that are needed.
Comment 3 Ben Kohler gentoo-dev 2016-04-28 20:44:36 UTC
Created attachment 432474 [details, diff]
ebuild diff for 122 -> 136
Comment 4 Ben Kohler gentoo-dev 2016-04-28 20:47:45 UTC
*** Bug 581476 has been marked as a duplicate of this bug. ***
Comment 5 Holger Hoffstätte 2016-04-29 00:20:34 UTC
Imported this into my overlay for testing, stumbled over
mcelog-1.0_pre3_p20120918-bashism.patch not applying correctly
since it lacks a leading entry in the patch path.
Added a/ & b/ in the patch: applies, builds, works. \o/

Afterwards I saw that your git repo contains the fixed version,
that should probably be attached here as well.

This update makes me happy because stopping & restarting mceclient
now works properly; the version in portage does not cleanly restart
without manual removal of a stale socket. This version still leaves
the /run/mcelog-client socket behind, but then starts correctly
anyway.

Should we delete the /run/mcelog-client socket on stop() in the start-stop-script while we're at it?
Comment 6 Oleh 2017-01-16 06:33:10 UTC
any stoppers in making this version added?
Comment 7 Matt Turner gentoo-dev 2017-03-08 02:07:34 UTC
I guess we were just waiting on a proxy maintainer to commit it? Not sure.

Anyway, I bumped it to 148 after applying Ben's EAPI=6 changes, and updating the two patches.

commit 1c87fc4663268b5dddb1c933cdbd249d0ef4460a
Author: Matt Turner <mattst88@gentoo.org>
Date:   Tue Mar 7 17:58:13 2017 -0800

    app-admin/mcelog: Version bump to 148.