Bug 570716 – games-strategy/s25rttr-0.8.1 with >=cmake-3.0: Policy CMP0053 is not set

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description tt_1 2016-01-03 12:00:59 UTC]

Created attachment 421766 [details]
build log after src_prepare executed

Policy CMP0053 is not set: Simplify variable reference and escape sequence
  evaluation.  Run "cmake --help-policy CMP0053" for policy details.  Use the
  cmake_policy command to set the policy and suppress this warning.
  For input:

    '
      /* __IBMC__ = VRP */
    # define @PREFIX@COMPILER_VERSION_MAJOR @MACRO_DEC@(__IBMC__/100)
    # define @PREFIX@COMPILER_VERSION_MINOR @MACRO_DEC@(__IBMC__/10 % 10)
    # define @PREFIX@COMPILER_VERSION_PATCH @MACRO_DEC@(__IBMC__    % 10)'

  the old evaluation rules produce:

    '
      /* __IBMC__ = VRP */
    # define /usr/gamesCOMPILER_VERSION_MAJOR @MACRO_DEC@(__IBMC__/100)
    # define /usr/gamesCOMPILER_VERSION_MINOR @MACRO_DEC@(__IBMC__/10 % 10)
    # define /usr/gamesCOMPILER_VERSION_PATCH @MACRO_DEC@(__IBMC__    % 10)'

  but the new evaluation rules produce:

    '
      /* __IBMC__ = VRP */
    # define @PREFIX@COMPILER_VERSION_MAJOR @MACRO_DEC@(__IBMC__/100)
    # define @PREFIX@COMPILER_VERSION_MINOR @MACRO_DEC@(__IBMC__/10 % 10)
    # define @PREFIX@COMPILER_VERSION_PATCH @MACRO_DEC@(__IBMC__    % 10)'



And so on. This doesn't seem to be a serious issue as it compiles, but I would like to see it getting fixed. Also it has been fixed upstream recently, so I will try to backport and provide a patch.

[Comment 1 tt_1 2016-01-03 12:19:17 UTC]

Created attachment 421768 [details, diff]
proposed patch

please review/test before commiting, thank you.

[Comment 2 tt_1 2016-01-24 22:26:05 UTC]

ping?

[Comment 3 Mr. Bones. (RETIRED) 2016-04-20 18:42:01 UTC]

definitely quieter so it's in portage.  thanks for the bug report and patch.