569876 – virtualx.eclass: virtx(): incorrect diagnostic messages

Bug 569876 - virtualx.eclass: virtx(): incorrect diagnostic messages

Summary: virtualx.eclass: virtx(): incorrect diagnostic messages

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Gentoo X packagers

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2015-12-26 23:58 UTC by Davide Pesavento
Modified:	2015-12-27 08:29 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Davide Pesavento (RETIRED) gentoo-dev

2015-12-26 23:58:22 UTC

Commit 161f0861de512991a879a50b2868c503f4715352 forgot to update a couple of spots in the new virtx function, namely:

       	debug-print "${FUNCNAME}: ${VIRTUALX_COMMAND} \"$@\""

and the die message:

        [[ ${retval} -ne 0 ]] && die "${FUNCNAME}: the ${VIRTUALX_COMMAND} failed."

VIRTUALX_COMMAND is not used by virtx(), the command is "$@".

Comment 1 Davide Pesavento (RETIRED) gentoo-dev

2015-12-27 00:07:49 UTC

https://github.com/gentoo/gentoo/pull/532

Comment 2 Justin Lecher (RETIRED) gentoo-dev

2015-12-27 08:29:45 UTC

commit 59e0cdef8d97610eda3ea3f28bdf562376a828a0
Author: Davide Pesavento <davidepesa@gmail.com>
Date:   Sun Dec 27 01:04:28 2015 +0100

    virtualx.eclass: fix diagnostic messages in virtx()

    Gentoo-Bug: 569876