I am requesting that vbam be bumped to version 2.0.0_beta2 and the previous version (2.0.0_pre1507) be renamed to version 2.0.0_alpha1507. My proposed changes can be seen here https://github.com/gentoo/gentoo/compare/master...nvinson:vbam-2.0.0_beta2. Reproducible: Always
Created attachment 419830 [details, diff] vbam ebuild updates This attachment contains the same changes as the code branch on github that I pointed to above.
Created attachment 421256 [details, diff] vbam ebuild updates The wx port of vbam was not installed correctly with the previous proposed ebuild. This update fixes that issue.
I looked at this and have some comments! :) > ++ INSTALL(PROGRAMS ${PROJECT_BINARY_DIR}/visualboyadvance-m${CMAKE_EXECUTABLE_SUFFIX} DESTINATION /usr/games/bin) This is problematic. If we use games.eclass, the install directories should be user configurable through the GAMES_{BIN,DATA,...}DIR variables. See the documentation for games.eclass for details. There is a sed in src_prepare() you could leverage for this, though. ;) > + ESVN_REPO_URI="https://github.com/visualboyadvance-m/visualboyadvance-m.git" ? + inherit git We don't have a git.eclass (anymore). + [[ ${PV} == 9999 ]] && subversion_pkg_preinst ?
(In reply to eroen from comment #3) > I looked at this and have some comments! :) > > > ++ INSTALL(PROGRAMS ${PROJECT_BINARY_DIR}/visualboyadvance-m${CMAKE_EXECUTABLE_SUFFIX} DESTINATION /usr/games/bin) > > This is problematic. If we use games.eclass, the install directories should > be user configurable through the GAMES_{BIN,DATA,...}DIR variables. See the > documentation for games.eclass for details. There is a sed in src_prepare() > you could leverage for this, though. ;) The games.eclass shouldn't be used as it has been deprecated. Furthermore, if this ebuild was updated to use EAPI 6 (and it should be), then games.eclass cannot be used as it is banned under EAPI 6. That said, a proper patch would allow the directories to be configured via variables instead of hard coding them. Anyone interested in writing such a patch should probably look into updating cmakelists.txt to use the GNUInstallDirs cmake module. > > > + ESVN_REPO_URI="https://github.com/visualboyadvance-m/visualboyadvance-m.git" > > ? > > + inherit git > > We don't have a git.eclass (anymore). > > + [[ ${PV} == 9999 ]] && subversion_pkg_preinst > > ? Anything related to the 9999 ebuild should probably be removed (especially since there is no 9999 ebuild). I, personally, have no issue in updating the ebuild to address the comments and issues mentioned above, but I would like to see a comment from games first about the likelihood of vbam being bumped to this version (as there's no point in updating the ebuild for this version if it's not likely to get added to portage).
commit 6600eb6642e3f67d15edb73522aa406caad8f7f9 Author: Nicholas Vinson <nvinson234@gmail.com> Date: Sat Dec 19 10:10:43 2015 -0500 games-emulation/vbam: Add new snapshot Gentoo-bug: 568802, 592098, 601838 * [QA] Remove games.eclass * EAPI=6 * Respect user flags
