Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 568800 - app-backup/rdiff-backup: Compatibility patch needed for >=net-libs/librsync-2.0.0
Summary: app-backup/rdiff-backup: Compatibility patch needed for >=net-libs/librsync-2...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Alessandro Calorì
URL: http://pkgs.fedoraproject.org/cgit/rp...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-19 16:44 UTC by Torsten Kaiser
Modified: 2016-02-25 08:05 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log from rdiff-backup (build.log,9.24 KB, text/plain)
2015-12-19 16:44 UTC, Torsten Kaiser
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Torsten Kaiser 2015-12-19 16:44:17 UTC
Created attachment 419828 [details]
build.log from rdiff-backup

After upgrading net-libs/librsync portage says:
!!! existing preserved libs:
>>> package: net-libs/librsync-2.0.0
 *  - /usr/lib64/librsync.so.1
 *  - /usr/lib64/librsync.so.1.0.2
 *      used by /usr/lib64/python2.7/site-packages/rdiff_backup/_librsync.so (app-backup/rdiff-backup-1.3.3-r1)

Trying to rebuild rdiff-backup fails with:

x86_64-pc-linux-gnu-gcc -pipe -march=amdfam10 -O3 -fomit-frame-pointer -fivopts -fweb -frename-registers -ftracer -fPIC -I/usr/include/python2.7 -c _librsyncmodule.c -o /var/tmp/portage/app-backup/rdiff-
backup-1.3.3-r1/work/rdiff-backup-1.3.3-python2_7/temp.linux-x86_64-2.7/_librsyncmodule.o
_librsyncmodule.c: In function ‘_librsync_new_sigmaker’:
_librsyncmodule.c:63:17: error: ‘RS_DEFAULT_STRONG_LEN’ undeclared (first use in this function)
         (size_t)RS_DEFAULT_STRONG_LEN);
                 ^
_librsyncmodule.c:63:17: note: each undeclared identifier is reported only once for each function it appears in
_librsyncmodule.c:62:17: error: too few arguments to function ‘rs_sig_begin’
   sm->sig_job = rs_sig_begin((size_t)blocklen,
                 ^
In file included from _librsyncmodule.c:25:0:
/usr/include/librsync.h:370:11: note: declared here
 rs_job_t *rs_sig_begin(size_t new_block_len,
           ^
error: command 'x86_64-pc-linux-gnu-gcc' failed with exit status 1


emerge --info rdiff-backup librsync:

Portage 2.2.26 (python 3.4.3-final-0, default/linux/amd64/13.0, gcc-4.9.3, glibc-2.22-r1, 4.3.0-rc7 x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-4.3.0-rc7-x86_64-AMD_Phenom-tm-_II_X6_1090T_Processor-with-gentoo-2.2
KiB Mem:    12279968 total,   5976632 free
KiB Swap:   25165756 total,  25140636 free
Timestamp of repository gentoo: Sat, 19 Dec 2015 09:30:01 +0000
sh bash 4.3_p42
ld GNU ld (Gentoo 2.25.1 p1.1) 2.25.1
app-shells/bash:          4.3_p42::gentoo
dev-java/java-config:     2.2.0::gentoo
dev-lang/perl:            5.22.0::gentoo
dev-lang/python:          2.7.11-r1::gentoo, 3.4.3-r6::gentoo, 3.5.1-r1::gentoo
dev-util/cmake:           3.4.1::gentoo
dev-util/pkgconfig:       0.29::gentoo
sys-apps/baselayout:      2.2::gentoo
sys-apps/openrc:          0.19.1::gentoo
sys-apps/sandbox:         2.10::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69-r1::gentoo
sys-devel/automake:       1.11.6-r2::gentoo, 1.12.6-r1::gentoo, 1.13.4-r1::gentoo, 1.14.1-r1::gentoo, 1.15-r1::gentoo
sys-devel/binutils:       2.25.1-r1::gentoo
sys-devel/gcc:            4.8.5::gentoo, 4.9.3::gentoo, 5.3.0::gentoo
sys-devel/gcc-config:     1.8::gentoo
sys-devel/libtool:        2.4.6-r1::gentoo
sys-devel/make:           4.1-r1::gentoo
sys-kernel/linux-headers: 4.3::gentoo (virtual/os-headers)
sys-libs/glibc:           2.22-r1::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000

local
    location: /root/ebuilds
    masters: gentoo
    priority: 0

java
    location: /usr/portage-local/layman/java
    masters: gentoo
    priority: 50

mozilla
    location: /usr/portage-local/layman/mozilla
    masters: gentoo
    priority: 50

sunrise
    location: /usr/portage-local/layman/sunrise
    masters: gentoo
    priority: 50

x11
    location: /usr/portage-local/layman/x11
    masters: gentoo
    priority: 50

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-pipe -march=amdfam10 -O3 -fomit-frame-pointer -fivopts -fweb -frename-registers -ftracer"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt /var/bind /var/lib/hsqldb"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.6/ext-active/ /etc/php/apache2-php7.0/ext-active/ /etc/php/cgi-php5.6/ext-active/ /etc/php/cgi-php7.0/ext-active/ /etc/php/cli-php5.6/ext-active/ /etc/php/cli-php7.0/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-pipe -march=amdfam10 -O3 -fomit-frame-pointer -fivopts -fweb -frename-registers -ftracer"
DISTDIR="/usr/portage/distfiles"
EMERGE_DEFAULT_OPTS="--with-bdeps y --jobs=6 --load-average=7 --keep-going"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs buildpkg config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms splitdebug strict unknown-features-warn unmerge-logs unmerge-orphans usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_GB.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j6"
PKGDIR="/var/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
USE="3dnow 3dnowext 7zip S3TC X a52 aac aalib ace acl acpi ads aften aio alisp alsa altenburgcards amarok amd64 amr amrnb amrr amrwb animgif ao apache2 apng aqua_theme archive async audacious audiofile aura autoipd avahi bcel bcp bdf beagle berkdb bidi bigpatch binfilter bittorrent bl blas blender-game bluetooth bonusscripts boost bzip2 c++ cairo calendar caps carbone_theme cblas-external cdda cdio cdparanoia cdr cgi chm chroot cifsupcall cisco clang cli clucene cmdctrl cmdsubmenu colord compress connectionstatus consolekit contactnotes contrib corefonts cpio cpufreq cracklib crypt cryptsetup cscope css ctype cups curl cutterlimit cutterqueue cuttime cvs cvsgraph cxx dar64 dbase dbm dbus dbx dc1394 dec_av dec_av2 declarative demo designer device-mapper divx djvu dlz dmi dmx dnotify doc domainkeys dot double-precision dpmod dri dts dv dvb dvbplayer dvd dvdarchive dvdchapjump dvdr dvdread dvi ecc editor egl elf emoticon encode enscript equalizer evdev excel exif exiv2 expat extensions extra extra-algorithms extra-cardsets extraengine extras fat fbcon fdt festival ffmpeg fftw file file-icons flac fluidsynth fmod font-server fontconfig fortran fping fpx ftp fts3 fuse g3dvl gbm gcj gd gdbm gecko geoip gflags gif gimp git gkrellm glade glamor gles gles1 gles2 glib glibc-omitfp glitz glsa glut gmedia gmp gnutls gopher gpac gpg gpgme gphoto2 graphics graphite graphviz gs gstreamer gtk gtk3 gutenprint gzip hddtemp hdri highlight history html htmlhandbook http httpd hvm hwdb ical iceweasel iconv icq icu id3 id3tag ide idea ieee1394 image imagemagick imap import-filter infowidget inherit-graph inkjar innodb inotify introspection ipfilter ipsec iptc ipv6 irc irrlicht ithreads jabber jack jad jadetex java java-external java6 jce jemalloc jingle jit jni john jpeg jpeg2k juju jumpplay kde kdecards kdepim kdrive kerberos kexi kipi kmid kpathsea ktts kvm latex lcms ldap libcaca libkms libmpeg2 libmysqlclient libnotify libsamplerate libsexy libssh2 libvisual libwww liemikuutio lights lirc lircsettings livebuffer llvm llvm-shared-libs lm_sensors logrotate logviewer loop-playback lto lua lucene lyx lzma lzo mad magic mail mailwrapper mainmenuhooks maps masquerade math matroska maya-shaderlibrary mbox mbrola md5sum mdev mdnsresponder-compat meanwhile menu-plugin menubar menuorg messages metric mhash midi mikmod mime mimencode minizip mixer mjpeg mmap mmx mmxext mng mod modplug modules mounts-check mozdevelop mozdom mozilla mp2 mp3 mp4 mp4live mpd mpeg mpeg2 mpg123 mplayer mppe-mppc mpu401 mschap msn mtp multilib multiprocess musepack music mysql mysqli mythtv nagios-dns nagios-ntp nagios-ping nagios-ssh nat ncurses nepomuk net netjack netmeeting network network-cron networkmanager nfs nfsidmap nfsv4 nfsv41 nls nntp normalize nova nptl nsplugin nspr nss ntfs ntfsprogs nuv offensive ogg ogg123 ole opcache opencl openexr opengl openmp openssh openssl openvpn opus osmesa pam pango pascal pcap pcre pcre16 pda pdf pdfimport perl php physfs pixmaps pkcs11 plasma player pmu png policykit portaudio posix postfix postproc postscript povray pptp pth pulseaudio python qemu qml qt3support qt4 qt5 query-browser quicktime r600-llvm-compiler radio rar raw rc5 rdesktop rdp readline realmedia remix replaygain restrict-javascript rle rpc rss rtc rtmp rtsp samba sasl sbig scanner screen script sdk sdl sdl-image sdl-sound sdlaudio seamonkey search seccomp secure-delete semantic-desktop sensord server session shared-dricore shorten shout sid signatures simplexml skins smime smp smtp sndfile sockets socks5 solver songs sortrecords sound soundex sounds sox speech speedo speex spell spice sql sqlite sqlite3 srtp sse sse2 sse3 sse4a ssl stars stats stemmer stlport stream submenu subtitles subversion suhosin svg svgz swat sylpheed sysfs syslog system-cairo system-icu system-jpeg system-jsoncpp system-libvncserver system-libvpx system-sqlite systray sysvipc szip t1lib taglib tagwriting tb4 tcpd teletext tetex tex texteffect textures tftp tga themes theora thesaurus threads threadsafe tidy tiff timercmd timerinfo tk tls toolbar tools transcode trayicon truetype tta ttxtsubs twolame udev udisks ui unicode unlock-notify upcall usb usbredir userfiles utils uudeview uuencode v4l v4l2 vaapi vamp vcd vcdx vdpau vdr video videos view vim-syntax virgl visualization vlm vnc vncviewer voice volctrl vorbis vorbis-psy vpx wav wavpack wayland wayland-compositor web webdav webinterface webkit webm webp widgets wifi winbind winpopup wireshark wma wmf wmp wxwidgets x264 x265 xa xanim xattr xcb xcf xcomposite xephyr xetex xext xface xforms xfs xft xhtml xine xinerama xkb xml xmp xnest xorg xosd xplanet xpm xrandr xrender xscreensaver xsl xslt xspice xv xvfb xvid xvmc xvnc xwayland yahoo yv12 zeroconf zip zlib zrtp zvbi" ABI_X86="32 64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" APACHE2_MPMS="worker" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext popcnt sse sse2 sse3 sse4a 3dnow 3dnowext" CURL_SSL="nss" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="de en" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_4" QEMU_SOFTMMU_TARGETS="x86_64 alpha arm i386 m68k mips mips64 mips64el mipsel ppc ppc64 ppcemb s390x sparc sparc64" RUBY_TARGETS="ruby20" USERLAND="GNU" VIDEO_CARDS="dummy fbdev v4l vesa radeon r600" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON

=================================================================
                        Package Settings
=================================================================

app-backup/rdiff-backup-1.3.3-r1::gentoo was built with the following:
USE="-examples" ABI_X86="64" ELIBC="glibc" KERNEL="linux" PYTHON_TARGETS="python2_7" USERLAND="GNU"


net-libs/librsync-2.0.0::gentoo was built with the following:
USE="" ABI_X86="64" ELIBC="glibc" KERNEL="linux" USERLAND="GNU"
Comment 1 Alessandro Calorì 2015-12-21 09:39:11 UTC
Latest version of rdiff-backup is compatible ONLY with librsync-0.9.7.
Comment 2 Ian Delaney (RETIRED) gentoo-dev 2015-12-29 07:08:38 UTC
It is known that  net-libs/librsync-2.0.0 is incompatible with the latest version of rdiff-backup
Comment 3 lubos.pavlicek 2016-01-27 17:47:34 UTC
rdiff-backup is compatible with librsync-1.0.0 after applying small patch to _librsyncmodule.c from 

http://pkgs.fedoraproject.org/cgit/rpms/rdiff-backup.git/plain/rdiff-backup-1.2.8-librsync-1.0.0.patch

This patch also working pro rdiff-backup-1.3.3

librsync-2.0.0 is binary compatible with librsync-1.0.0, see http://librsync.sourcefrog.net/md_NEWS.html. But in librsync-2.0.0 is big bug in rs_search_for_block function, see https://github.com/librsync/librsync/issues/50, patch for librsync-2.0.0 is available at https://github.com/librsync/librsync/pull/59

Rdiff-backup-1.3.3 is working after applying both patches.
Comment 4 Ian Delaney (RETIRED) gentoo-dev 2016-02-02 08:12:04 UTC
axelgenus ??
Comment 5 Alessandro Calorì 2016-02-02 09:20:03 UTC
I'm not the maintainer of rdiff-backup. I'm reassigning this bug to Alex Brandt.

I'm following the librsync's bug #573144 which has been fixed in portage.
Comment 6 Kristian Fiskerstrand (RETIRED) gentoo-dev 2016-02-02 09:38:06 UTC
(In reply to lubos.pavlicek from comment #3)
> rdiff-backup is compatible with librsync-1.0.0 after applying small patch to
> _librsyncmodule.c from 
> 
> http://pkgs.fedoraproject.org/cgit/rpms/rdiff-backup.git/plain/rdiff-backup-
> 1.2.8-librsync-1.0.0.patch
> 
> This patch also working pro rdiff-backup-1.3.3
> 
> librsync-2.0.0 is binary compatible with librsync-1.0.0, see
> http://librsync.sourcefrog.net/md_NEWS.html. But in librsync-2.0.0 is big
> bug in rs_search_for_block function, see
> https://github.com/librsync/librsync/issues/50, patch for librsync-2.0.0 is
> available at https://github.com/librsync/librsync/pull/59
> 
> Rdiff-backup-1.3.3 is working after applying both patches.

Thanks for the pointer
Comment 7 Alex Brandt (RETIRED) gentoo-dev 2016-02-06 15:58:42 UTC
I no longer maintain app-backup/rdiff-backup but can apply the patch if truly required.  I'd also like to hear why people use rdiff-backup over alternate solutions.  Please, email me at my gentoo address so we can discuss the details.
Comment 8 Kristian Fiskerstrand (RETIRED) gentoo-dev 2016-02-08 15:06:09 UTC
(In reply to Alex Brandt from comment #7)
> I no longer maintain app-backup/rdiff-backup but can apply the patch if
> truly required.  I'd also like to hear why people use rdiff-backup over
> alternate solutions.  Please, email me at my gentoo address so we can
> discuss the details.

In that case I suggest lastriting it for regular removal rather than dropping yet another package to maintainer-needed.
Comment 9 Alex Brandt (RETIRED) gentoo-dev 2016-02-08 16:01:00 UTC
Will set that process up as soon as I get a spare moment.
Comment 10 Tobias Leupold 2016-02-13 08:02:41 UTC
As this is probably of interest for this issue (and for rdiff-backup in gentoo at all): As of today, rdiff-backup has a maintainer again, cf. http://lists.nongnu.org/archive/html/rdiff-backup-users/2016-02/msg00009.html
Comment 11 Alessandro Calorì 2016-02-13 08:25:33 UTC
If no one wants to maintain rdiff-backup and since it seems there is activity again on this project[¹] I can take this package over. I'll provide an updated ebuild ASAP with a PL on GitHub.

[1] https://github.com/sol1/rdiff-backup
Comment 12 Wes 2016-02-15 12:58:35 UTC
(In reply to Alessandro Calorì from comment #11)
> If no one wants to maintain rdiff-backup and since it seems there is
> activity again on this project[¹] I can take this package over. I'll provide
> an updated ebuild ASAP with a PL on GitHub.
> 
> [1] https://github.com/sol1/rdiff-backup

Hi Alessandro, I had been talking to alunduil about taking over maintainership of rdiff-backup as part of our (my employer's) stewardship of upstream.  I'm happy to collaborate on it though and see you've been working on bringing it up to date already.  I've messaged you on Freenode to discuss further.

Cheers,
Wes
Comment 13 Ian Delaney (RETIRED) gentoo-dev 2016-02-25 08:05:14 UTC
commit c91e5a92d0c814abe968fbddbdab397494101bb1
Author: Alessandro Calorì <axelgenus@gmail.com>
Date:   Sun Feb 14 19:35:51 2016 +0100

    app-backup/rdiff-backup: clean up, fix #568800