Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 568762 - eutils.eclass: eshopts_push fails with empty option flags
Summary: eutils.eclass: eshopts_push fails with empty option flags
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2015-12-19 14:02 UTC by Ulrich Müller
Modified: 2022-01-10 10:24 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Properly quote argument in eshopts_push(). (0001-eutils.eclass-Properly-quote-argument-in-eshopts_pus.patch,755 bytes, patch)
2015-12-19 14:02 UTC, Ulrich Müller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2015-12-19 14:02:22 UTC
Created attachment 419772 [details, diff]
Properly quote argument in eshopts_push().

The following sequence of commands (e.g. in src_install):

    set +$-
    eshopts_push
    eshopts_pop

... fails with:

 * ERROR: app-misc/foo-2::local failed (install phase):
 *   eshopts_pop: unbalanced push
 * 
 * Call stack:
 *     ebuild.sh, line  133:  Called src_install
 *   environment, line 1982:  Called eshopts_pop
 *   environment, line  833:  Called die
 * The specific snippet of code:
 *       estack_pop eshopts s || die "${FUNCNAME}: unbalanced push";

Attached patch should fix it.
Comment 1 Ulrich Müller gentoo-dev 2022-01-10 10:24:12 UTC
This has been fixed a long time ago.