Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 56874 - gimp-1.2.5-r1 (Update)
Summary: gimp-1.2.5-r1 (Update)
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: http://bugzilla.gnome.org/show_bug.cg...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-13 01:40 UTC by Bruno Redondi
Modified: 2004-07-19 05:52 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for the ebuild (gimp-1.2.5-r1.diff,340 bytes, patch)
2004-07-13 01:41 UTC, Bruno Redondi
Details | Diff
colormetric patch (gimp-1.2.5-colormetric.patch,8.81 KB, patch)
2004-07-13 01:41 UTC, Bruno Redondi
Details | Diff
new dither patch (gimp-1.2.5-riemersmadither.patch,17.63 KB, patch)
2004-07-13 01:42 UTC, Bruno Redondi
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bruno Redondi 2004-07-13 01:40:26 UTC
Those are two enhancement to gimp.
colormetric.patch: Revised the idea of color distance based on a paper by Thiadmer Riemersma (http://www.compuphase.com/cmetric.htm). Now RGB->INDEXED does not map dark colors to blue or light grays to yellow.
riemersmadither.patch: Created a new dither option based on a paper by Thiadmer Riemersma (http://www.compuphase.com/riemer.htm). This algorithm combines the advantages of ordered dither and error diffusion dither.
Comment 1 Bruno Redondi 2004-07-13 01:41:09 UTC
Created attachment 35297 [details, diff]
patch for the ebuild
Comment 2 Bruno Redondi 2004-07-13 01:41:34 UTC
Created attachment 35298 [details, diff]
colormetric patch
Comment 3 Bruno Redondi 2004-07-13 01:42:02 UTC
Created attachment 35299 [details, diff]
new dither patch
Comment 4 foser (RETIRED) gentoo-dev 2004-07-13 02:37:48 UTC
this changes the behaviour of certain functionality right ? I'm not sure that is a good thing to do by default. What is the upstream take on this ?
Comment 5 Bruno Redondi 2004-07-13 03:40:41 UTC
The colormetric patch simply updates the formula used in comparison of two rgb colors (adding one more variable) without changes to the main algorithm, so I consider it as a bugfix. The other patch simply adds a new feature, no changes to the rest of the code.
I cannot submit this patch directly to gimp manteiners because they accept patches only for the latest version (2.x), currently I'm working on the patch for that release. 
Comment 6 foser (RETIRED) gentoo-dev 2004-07-13 05:35:14 UTC
I discussed with the upstream gimp maintainers, they would like to see these patches proposed in their bugzilla (http://bugzilla.gnome.org/enter_bug.cgi?product=GIMP) or on their mailinglist.

The Gentoo devs cannot really judge these patches for their pros/cons like they can, so without their go-ahead I'm not confident we should put this in.

If you have filed these patches please add the upstream buglinks to this report.
Comment 7 Bruno Redondi 2004-07-13 06:20:16 UTC
submitted to upstream as bug #147481