Created attachment 419318 [details, diff] install-xattr-prefix-and-tidy.patch This upstream has a hard-coded install prefix of $(DESTDIR)/usr. "default" means __eapi4_src_install() which does the standard emake DESTDIR=$D thing so our file winds up in ${D}/usr/bin instead of ${ED}/usr/bin. Proposed solution: hack up the Makefile to hard-code ${EPREFIX}/usr instead of just /usr. While at it, I couldn't resist getting rid of all the redundant conditionals in the ebuild -- the first one is enough to get the job done. https://github.com/gentoo/gentoo/pull/479
1) i'm not going to apply these patches to the stable versions, we'll proceed with the next 2) you broke the 9999 version because install-xattr is housed in the elfix.git repository under misc. I can put that back, but I mention it because that's where we want that fix to go 3) I am upstream so if you want something in the Makefile, look at that as it might be a nicer solution. 4) while i look at stuff on github, any non-trivial discussions about packages needs to be done on bugzilla.
(In reply to Anthony Basile from comment #1) > 2) you broke the 9999 version because install-xattr is housed in the > elfix.git repository under misc. I can put that back, but I mention it > because that's where we want that fix to go look again
(In reply to Gregory Turner from comment #2) > (In reply to Anthony Basile from comment #1) > > 2) you broke the 9999 version because install-xattr is housed in the > > elfix.git repository under misc. I can put that back, but I mention it > > because that's where we want that fix to go > > look again The miss-ability of what I did could be solved by adding some whitespace. The reason I did it that way was so -9999 and 0.5 would both harness the standard phase functions without tons of conditionals (all three ebuilds become identical in my patch except for KEYWORDS).
okay we'll carry this moving forward. i probably have to push out a new version soon anyhow.
(In reply to Anthony Basile from comment #4) > okay we'll carry this moving forward. i probably have to push out a new > version soon anyhow. lovely, prefix denizens of the future thank you :) (the probable reason this didn't come up sooner: prefix-overlay failed to capture the xattr useflag dependency that upstream added some time ago, so even if you said "+xattr" nothing very xattr-ey actually happened. :) )
