Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 56790 - request, TkZinc ebuild
Summary: request, TkZinc ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Doug Goldstein (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-12 06:31 UTC by Felix Lee
Modified: 2004-08-08 07:53 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Tkzinc-3.2.100.ebuild (Tkzinc-3.2.100.ebuild,876 bytes, text/plain)
2004-08-06 03:06 UTC, Ming Zhao (RETIRED)
Details
without-opengl.patch (without-opengl.patch,266 bytes, patch)
2004-08-06 03:07 UTC, Ming Zhao (RETIRED)
Details | Diff
Tkzinc-3.2.100.ebuild (Tkzinc-3.2.100.ebuild,868 bytes, text/plain)
2004-08-07 04:54 UTC, Ming Zhao (RETIRED)
Details
wipe-popup.patch (wipe-popup.patch,457 bytes, patch)
2004-08-08 00:58 UTC, Ming Zhao (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Lee 2004-07-12 06:31:18 UTC
http://www.tkzinc.org/
TkZinc is a widget for Tk that's similar to the Canvas widget, but provides more powerful graphics capabilities like splines and groups and alpha blending and so forth.  It's cross-platform and usable from tcl, python, and perl.  It seems to me like a good way to quickly build apps and games with scalable vector graphics.


Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Ming Zhao (RETIRED) gentoo-dev 2004-08-06 03:06:55 UTC
Created attachment 36874 [details]
Tkzinc-3.2.100.ebuild
Comment 2 Ming Zhao (RETIRED) gentoo-dev 2004-08-06 03:07:25 UTC
Created attachment 36875 [details, diff]
without-opengl.patch
Comment 3 Doug Goldstein (RETIRED) gentoo-dev 2004-08-07 00:42:38 UTC
Couple of things I noticed with the ebuild.

1. License: Is it LGPL-2 or LGPL-2.1 ? (It's LGPL-2 btw, I checked)
2. the without-opengl patch... shouldn't that only be applied when we don't have opengl in our USE flags?
3. any reason why you're not using emake instead of just make?
4. why not just use einstall. simplier
5. upon checking their site it says it requires TK 8.4, you need to make the deps reflect that.
Comment 4 Ming Zhao (RETIRED) gentoo-dev 2004-08-07 04:54:03 UTC
Created attachment 36937 [details]
Tkzinc-3.2.100.ebuild

fixed the problems above, except 2.
I don't think it's necessray to check "opengl" use flag before applying the
patch.
The original source is inconsistent without this patch: it checks "GL" macro
before implementing "InitRendering1" function, but uses "InitRendering1"
without checking "GL" macro.
Comment 5 Doug Goldstein (RETIRED) gentoo-dev 2004-08-07 17:38:01 UTC
Ming,

Just for your FYI. You were right with make DESTDIR=${D} install || die. That's a better method then einstall.

The RDEPENDs should have just all been DEPEND.

Also, the proper copyright line is to Gentoo Foundation.

the use doc && make pdf || die line is invalid... because the build will die if doc isn't in USE either.

Odd thing... during the emake ... it pops up a small window with the caption of tclsh8.4 and the make just stops at the following spot.

no files matched glob pattern "libTkzinc3.2.100.so"
rm -f libtess.a
ar cr libtess.a dict.o geom.o memalloc.o mesh.o normal.o priorityq.o render.o sweep.o tess.o tessmono.o
ranlib libtess.a
rm -f libTkzinc3.2.100.so
gcc -pipe -shared -o libTkzinc3.2.100.so Track.o Tabular.o Reticle.o Map.o Rectangle.o Arc.o Curve.o Item.o PostScript.o MapInfo.o Attrs.o Draw.o Geo.o List.o perfos.o Transfo.o Group.o Icon.o Text.o Image.o Color.o Field.o Triangles.o Window.o tkZinc.o  OverlapMan.o  -L/usr/X11R6/lib -lX11 -L. -ltess -lXext -lGL -L/usr/lib -ltclstub8.4 -L/usr/lib -ltkstub8.4
#ranlib libTkzinc3.2.100.so


Soon as you close the window, the build continues on and finishes successfully.

Ming will you look into this situation? For now I will commit the ebuild to CVS and you can pull the cleaned up one from there because we can just fix the problem while it's live because it won't affect the resulting files that are merged into the filesystem so we won't have to make a revision bump.

Comment 6 Ming Zhao (RETIRED) gentoo-dev 2004-08-08 00:58:00 UTC
Doug, 
Thanks for you modification and commit. 

I think the annoying popup window is caused by the following:
( echo package require Tk \; pkg_mkIndex -verbose -load Tk . libTkzinc3.2.100.so \; exit ) | TCL_LIBRARY=`echo /usr/lib/tcl8.4/include/library` LD_LIBRARY_PATH=".:/usr/lib:" LIBPATH=".:/usr/lib:" SHLIB_PATH=".:/usr/lib:" PATH=".:/usr/lib:/usr/lib/ccache/bin:/sbin:/usr/sbin:/usr/lib/portage/bin:/bin:/usr/bin:/usr/local/bin:/opt/bin:/usr/i686-pc-linux-gnu/gcc-bin/3.3:/opt/intel/compiler80/bin:/opt/Acrobat5:/usr/X11R6/bin:/opt/sun-jdk-1.4.2.05/bin:/opt/sun-jdk-1.4.2.05/jre/bin:/opt/sun-jdk-1.4.2.05/jre/javaws:/usr/qt/3/bin:/usr/kde/3.3/sbin:/usr/kde/3.3/bin:/usr/kde/3.2/sbin:/usr/kde/3.2/bin" TCLLIBPATH="." /usr/lib/../bin/tclsh8.4

If libTkzinc3.2.100.so hasn't been generated, a tclsh8.4 window will popup, otherwise it will not.

A minor change to Makefile.in may fix this problem, see my attachment.
Comment 7 Ming Zhao (RETIRED) gentoo-dev 2004-08-08 00:58:45 UTC
Created attachment 37002 [details, diff]
wipe-popup.patch
Comment 8 Doug Goldstein (RETIRED) gentoo-dev 2004-08-08 07:53:34 UTC
Good job Ming.

Patch committed to CVS. Works great.

Closing this bug out.