Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 567612 - x11-misc/x11vnc: -unixpw option broken
Summary: x11-misc/x11vnc: -unixpw option broken
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Alex Xu (Hello71)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 589164
  Show dependency tree
 
Reported: 2015-12-05 23:50 UTC by Paul B. Henson
Modified: 2016-11-27 21:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
updated ebuild (x11vnc-0.9.14-r1.ebuild,1.58 KB, text/plain)
2015-12-05 23:50 UTC, Paul B. Henson
Details
fix waitpid define checks (x11vnc-0.9.14-r1-waitpid.patch,1.44 KB, patch)
2015-12-05 23:51 UTC, Paul B. Henson
Details | Diff
fix other broken define checks (x11vnc-0.9.14-r1-fixdefines.patch,7.17 KB, patch)
2015-12-05 23:51 UTC, Paul B. Henson
Details | Diff
git format-patch for new ebuild and patches (0001-Add-x11vnc-0.9.14-r1-ebuild-resolving-bug-567612.patch,17.95 KB, patch)
2016-04-15 03:53 UTC, Paul B. Henson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Paul B. Henson 2015-12-05 23:50:33 UTC
Created attachment 418622 [details]
updated ebuild

As described in

https://github.com/LibVNC/x11vnc/issues/20

the -unixpw option is broken on Gentoo in released versions of x11vnc. This has been fixed by two commits upstream:

https://github.com/LibVNC/x11vnc/commit/a6852d61dce708bf5185a7e42770475a070433bc
https://github.com/LibVNC/x11vnc/commit/e70123d8f778e3f0c3bf1606f68a70b0d9748c6a

Attached are those two patches and an updated ebuild that applies them.
Comment 1 Paul B. Henson 2015-12-05 23:51:07 UTC
Created attachment 418624 [details, diff]
fix waitpid define checks
Comment 2 Paul B. Henson 2015-12-05 23:51:29 UTC
Created attachment 418626 [details, diff]
fix other broken define checks
Comment 3 Alex Xu (Hello71) 2015-12-06 14:22:10 UTC
please reference the upstream issues in the ebuild so that I can cross-reference them later during maintenance.

other than that, LGTM.

then, could you submit a git-format-patch for the whole thing against the Gentoo repository? thanks.
Comment 4 Paul B. Henson 2016-04-15 03:53:05 UTC
Created attachment 430544 [details, diff]
git format-patch for new ebuild and patches
Comment 5 Paul B. Henson 2016-04-15 03:55:36 UTC
Sorry for the long delay, for some reason I don't always get email from the gentoo bugzilla :(. I usually try and remember to do a search for all my bugs and check the status every now and again but I was busy and hadn't done one for a while. I get some but not all bugzilla mail, it's very annoying, I'm not sure where the blame lies.

Thanks...
Comment 6 SpanKY gentoo-dev 2016-11-27 21:18:01 UTC
i've added a -r1 to include these patches:
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=31d39424920068b244f74223e501fc462a40ca3a

thanks!