Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 567302 - net-libs/nodejs-5.2.0: version bump and various improvements to ebuild
Summary: net-libs/nodejs-5.2.0: version bump and various improvements to ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Johan Bergström
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-02 04:21 UTC by Alex Turbov
Modified: 2016-03-10 07:41 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
new ebuild (nodejs-5.1.0.ebuild,6.02 KB, text/plain)
2015-12-02 04:22 UTC, Alex Turbov
Details
disable dependencies tracking at build time (nodejs-5.1.0-no-deps-tracking.patch,501 bytes, patch)
2015-12-02 04:22 UTC, Alex Turbov
Details | Diff
nodejs 5.1.1 ebuild (nodejs-5.1.1.ebuild,6.20 KB, text/plain)
2015-12-09 13:38 UTC, Alex Turbov
Details
Fixed dependencies according notes (nodejs-5.2.0.ebuild,6.20 KB, text/plain)
2015-12-13 09:28 UTC, Alex Turbov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Turbov 2015-12-02 04:21:16 UTC
5.1.0 is out: https://nodejs.org/en/download/stable/

Also this ebuild has few refactorings:
1. remove more useless files from `$(libdir)/node_modules'
2. properly install man pages for `npm`
3. install bash completion for `npm`
4. introduce USE=doc and install nodejs API docs
5. do not use dependencies tracking while build (it is only useful for developers, but not for ine time build)

Reproducible: Always
Comment 1 Alex Turbov 2015-12-02 04:22:03 UTC
Created attachment 418310 [details]
new ebuild
Comment 2 Alex Turbov 2015-12-02 04:22:50 UTC
Created attachment 418312 [details, diff]
disable dependencies tracking at build time
Comment 3 Alex Turbov 2015-12-09 13:38:52 UTC
Created attachment 418848 [details]
nodejs 5.1.1 ebuild

meanwhile new version is out
Comment 4 Alex Turbov 2015-12-09 13:41:22 UTC
new features for 5.1.1 ebuild:

* remove references to online fonts from HTML docs, so the can be viewed offline (or slow/mobile connection) w/o problem (connection lags)
Comment 5 Alex Turbov 2015-12-11 04:25:20 UTC
meanwhile 5.2.0 is out... just rename 5.1.1 ebuild to 5.2.0
Comment 6 Johan Bergström 2015-12-11 04:34:27 UTC
Thanks for the ebuild updates!

Feedback:

1. libuv needs to be >= 1.7.5
2. icu? needs to be >= 56
3. http-parser needs to be >= 2.6.0
4. openssl needs to be >= 1.0.2e (security related)
5. IUSE=+snapshot based on upstream change
6. your cleanups should be wrapped in the npm use flag.

Also:
there's _a lot_ of test modification. I'm not super keen on doing this amount of changes; it indicates that something is off with how gentoo tests nodejs. Looking at http://ci.nodejs.org you can see it being tested on 8+ different linuxes. We should figure out why it fails in our sandboxed test mode and do something about it before we further distance ourselves to upstream.

If you want to take testing seriously, I suggest you ping me (jbergstroem@freenode) or open issues at http://github.com/nodejs/node where you can reproduce test issues outside of the gentoo sandbox.
Comment 7 Alex Turbov 2015-12-13 09:28:49 UTC
Created attachment 419078 [details]
Fixed dependencies according notes
Comment 8 Alex Turbov 2015-12-13 09:31:04 UTC
> 1. libuv needs to be >= 1.7.5
fixed

> 2. icu? needs to be >= 56
I don't see that ebuild in protage tree yet...

> 3. http-parser needs to be >= 2.6.0
> 4. openssl needs to be >= 1.0.2e (security related)
> 5. IUSE=+snapshot based on upstream change
fixed

6. your cleanups should be wrapped in the npm use flag.
some of them already under `if use npm`, the others are generic: cleaning `node_modules` which is not `npm` only.
Comment 9 Jonas Jelten 2016-01-14 23:50:14 UTC
https://github.com/nodejs/node/blob/v5.4.1/CHANGELOG.md

5.4.1 is out, please bump.
Comment 10 Johan Bergström 2016-01-15 03:45:52 UTC
Work in progress update that attempts to merge all of this plus additional fixes can be found in a git branch, please test and report back.

https://github.com/gentoo/gentoo/compare/master...jbergstroem:verbump/net-libs/nodejs-5.4.1
Comment 11 Joakim Tjernlund 2016-02-09 13:44:33 UTC
Could ppc be keyworded as well? I have read in nodejs release notes that
it supports ppc(for a while now).
Comment 12 Johan Bergström 2016-03-10 03:50:29 UTC
@Joakim: suggesting you open a PPC keywording bug.

Closing as fixed.
Comment 13 Joakim Tjernlund 2016-03-10 07:41:19 UTC
(In reply to Johan Bergström from comment #12)
> @Joakim: suggesting you open a PPC keywording bug.
> 
> Closing as fixed.

I did so here:
  https://bugs.gentoo.org/show_bug.cgi?id=576940

This is my first keywording request, I hope I got most right :)