Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 566878 - Please bump systemd.eclass to EAPI=6
Summary: Please bump systemd.eclass to EAPI=6
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo systemd Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-26 07:17 UTC by Martin Väth
Modified: 2015-12-01 22:12 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Väth 2015-11-26 07:17:49 UTC
It would be nice if systemd.eclass would finally be usable in EAPI=6, at least the basic functions like systemd_dounit(), systemd_dotmpfilesd(), systemd_with_unitdir().

I see nothing which requires any change for EAPI=6 except for the blocking test...
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-11-26 11:37:06 UTC
Well, I'd honestly ban systemd_with* and sysyemd_to_myeconfargs functions. And maybe add phase check to catalog update.
Comment 2 Martin Väth 2015-11-26 12:23:26 UTC
(In reply to Michał Górny from comment #1)
> Well, I'd honestly ban systemd_with* and sysyemd_to_myeconfargs functions.

This is just my personal opinion, of course:
I do not care whether they are banned or not.
Important is that e.g. systemd_get_unitdir() is kept; the rest are just convenience wrappers, anyway.

That being said, I guess that nobody will argue against banning the already obsoleted systemd_to_myeconfargs.
On the other hand, I see nothing wrong with systemd_with_unitdir(), because it seems that the option name --with-systemdsystemunitdir has become a quasi-standard and follows upstream's recommendation from e.g. http://www.freedesktop.org/software/systemd/man/daemon.html
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-11-27 14:54:20 UTC
Patches sent for review.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-12-01 22:12:58 UTC
And pushed.