Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 566802 - xfce-extra/xfpanel-switch-1.0.3 : New ebuild
Summary: xfce-extra/xfpanel-switch-1.0.3 : New ebuild
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Default Assignee for New Packages
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2015-11-25 11:41 UTC by Laurent V
Modified: 2018-08-16 08:46 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposal ebuild for xfce-extra/xfpanel-switch-1.0.3 (xfpanel-switch-1.0.3.ebuild,578 bytes, text/plain)
2015-11-25 11:41 UTC, Laurent V
Details
emerge --info (emerge-info,5.38 KB, text/plain)
2015-11-25 11:43 UTC, Laurent V
Details
Proposal ebuild for xfce-extra/xfpanel-switch-1.0.3 (xfpanel-switch-1.0.3.ebuild,592 bytes, text/plain)
2015-11-25 11:55 UTC, Laurent V
Details
xfpanel-switch-1.0.3 proposal ebuild (xfpanel-switch-1.0.3.ebuild,752 bytes, text/plain)
2015-12-11 11:13 UTC, Laurent V
Details
xfpanel-switch-1.0.7.ebuild (xfpanel-switch-1.0.7.ebuild,769 bytes, text/plain)
2018-07-26 13:13 UTC, Massimo Burcheri
Details
xfpanel-switch-1.0.7.ebuild (xfpanel-switch-1.0.7.ebuild,765 bytes, text/plain)
2018-07-26 13:27 UTC, Massimo Burcheri
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent V 2015-11-25 11:41:14 UTC
Created attachment 417828 [details]
Proposal ebuild for xfce-extra/xfpanel-switch-1.0.3

Hello ! 

I made an ebuild for a new application released for the Xfce desktop called xfpanel-switch.

This tool allow you to backup and restore Xfce panel layouts.

Upstream : https://launchpad.net/xfpanel-switch

My ebuild emerge fine but it might not be perfect at the moment. If there's any issues with it, I would happily fix them and learn something on the way.

Also, I'm willing to proxy-maintain it ! If it is possible, can you point me where I should ask ? 

Have a nice day, 

Laurent Vivier.
Comment 1 Laurent V 2015-11-25 11:43:08 UTC
Created attachment 417832 [details]
emerge --info
Comment 2 Laurent V 2015-11-25 11:55:01 UTC
Created attachment 417836 [details]
Proposal ebuild for xfce-extra/xfpanel-switch-1.0.3

Added --prefix=/usr since it should be the default install location
Comment 3 Ian Delaney (RETIRED) gentoo-dev 2015-12-05 13:35:33 UTC
Another good start except this also needs to inherit an eclass, a new python eclass.  It then takes on the var PYTHON_COMPAT used to set support to python 3.

# As stated on the README, it depend on python3-gi (Python Gobject Introspection)
I found the python3-gi is simply inbuilt into the emerged python 3.

DEPEND="${RDEPEND}" I would double check. Often not required.

The line ./configure changes with addition of the (new) python eclass.
Comment 4 Laurent V 2015-12-08 10:52:43 UTC
Hi Ian,

Thank you for your feedback on this !

I'm working on it but I've trouble to find the proper python eclass to inherit.

I tried to look for clues regarding src_configure within the python* elcass located here : https://wiki.gentoo.org/wiki/Project:Python/Eclasses but I didn't find anything useful so far.

Could you give me a hint on which eclass / function should I use to get rid of the "hardcoded" configure path ?

Have a nice day.

Laurent
Comment 5 Ian Delaney (RETIRED) gentoo-dev 2015-12-10 12:20:14 UTC
Well yes
https://wiki.gentoo.org/wiki/Project:Python
https://wiki.gentoo.org/wiki/Project:Python/python-r1.

You will also need the mandatory PYTHON_USEDEP with deps that require installed python modules.
Comment 6 Laurent V 2015-12-11 11:13:59 UTC
Created attachment 418978 [details]
xfpanel-switch-1.0.3 proposal ebuild

Hi Ian, 

Thanks again for the help and links. 

Here's the updated version of the ebuild, I'm not sure I've got everything right so feel free to correct me.

Have a nice day.

Laurent
Comment 7 Ian Delaney (RETIRED) gentoo-dev 2015-12-15 06:33:46 UTC
${S}/configure --prefix=/usr --python=python3:

The pwd at that point is already ${S}, so it can be taken out there.
--python=python3 is already taken care of by the use of PYTHON_COMPAT= and
inherit python-r1.
afaik the use of hasn't removed the need for [${PYTHON_USEDEP}] in dev-python/pygobject:3
i.e. dev-python/pygobject:3[${PYTHON_USEDEP}]
Comment 8 Ian Delaney (RETIRED) gentoo-dev 2015-12-15 06:34:45 UTC
correction;
afaik the use of EAPI 6 hasn't removed the need for [${PYTHON_USEDEP}] in dev-python/pygobject:3
Comment 9 Massimo Burcheri 2018-07-26 13:13:10 UTC
Created attachment 541108 [details]
xfpanel-switch-1.0.7.ebuild
Comment 10 Massimo Burcheri 2018-07-26 13:14:51 UTC
Hi, having few to no experience in ebuilds, I started updating this ebuild.
Updated to recent 1.0.7, EAPI=6, recent python 3.6, and moved pygobject from RDEPEND to DEPEND, isn't it requred at build time?

Would be fine to get that tool into Portage.
Comment 11 Massimo Burcheri 2018-07-26 13:27:15 UTC
Created attachment 541112 [details]
xfpanel-switch-1.0.7.ebuild

python_targets_python3_6 was installing, but failing at runtime:

Traceback (most recent call last):
  File "/usr/share/xfpanel-switch/xfpanel-switch/xfpanel-switch.py", line 29, in <module>
    import gi
ImportError: No module named 'gi'

I needed to switch back to python_targets_python3_5, building and working.
Comment 12 Massimo Burcheri 2018-08-16 07:37:24 UTC
Meanwhile xfpanel-switch was superseded by the official xfce4-panel-profiles:
https://git.xfce.org/apps/xfce4-panel-profiles/
-> bug 663760
Comment 13 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-08-16 08:46:09 UTC
I've seen a release of that package and were wondering if anybody wants it.