Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 56663 - vmware-workstation-4.5.2.8848-r1 wrong path when ./updating
Summary: vmware-workstation-4.5.2.8848-r1 wrong path when ./updating
Status: VERIFIED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Chris Gianelloni (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-11 02:50 UTC by Thomas Matthijs (RETIRED)
Modified: 2004-07-12 10:33 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Matthijs (RETIRED) gentoo-dev 2004-07-11 02:50:42 UTC
Calculating dependencies ...done!
>>> emerge (1 of 1) app-emulation/vmware-workstation-4.5.2.8848-r1 to /
>>> md5 src_uri ;-) VMware-workstation-4.5.2-8848.tar.gz
>>> md5 src_uri ;-) vmware-any-any-update75.tar.gz
>>> Unpacking source...
>>> Unpacking VMware-workstation-4.5.2-8848.tar.gz to /var/tmp/portage/vmware-workstation-4.5.2.8848-r1/work
 * Adding 2.{5,6}.x kernel support
>>> Unpacking vmware-any-any-update75.tar.gz to /var/tmp/portage/vmware-workstation-4.5.2.8848-r1/work/vmware-distrib
/usr/sbin/ebuild.sh: line 50: ./update: No such file or directory
/usr/sbin/ebuild.sh: line 51: ./update: No such file or directory
/usr/sbin/ebuild.sh: line 52: ./update: No such file or directory
/usr/sbin/ebuild.sh: line 53: ./update: No such file or directory
>>> Source unpacke

quick fix:
--- /usr/portage/app-emulation/vmware-workstation/vmware-workstation-4.5.2.8848-r1.ebuild       2004-07-11 11:49:49.965339040 +0200
+++ ./vmware-workstation-4.5.2.8848-r1.ebuild   2004-07-11 11:49:41.559616904 +0200
@@ -47,6 +47,7 @@
                cd ${S}
                unpack ${N26KernSupport}.tar.gz
                mv -f ${N26KernSupport}/*.tar ${S}/lib/modules/source/
+               cd ${N26KernSupport}
                ./update vmware ../bin/vmware
                ./update bridge ../bin/vmnet-bridge
                ./update vmx ../lib/bin/vmware-vmx
Comment 1 Chris Gianelloni (RETIRED) gentoo-dev 2004-07-11 09:15:00 UTC
Already fixed in CVS... thanks for the report
Comment 2 Thomas Matthijs (RETIRED) gentoo-dev 2004-07-11 11:02:27 UTC
should have revision bumped it, the ebuild merges without errors ....

and maybe add some || die on the update lines
Comment 3 Chris Gianelloni (RETIRED) gentoo-dev 2004-07-11 13:20:35 UTC
Why did you reopen this?
Comment 4 Thomas Matthijs (RETIRED) gentoo-dev 2004-07-11 14:04:01 UTC
because its not 'fixed'.

you changed the ebuild but did not revision bump it,
the ebuild merges fine with the errors and installs an incorrect version
so it shuold be bumped to fix it
anyone who synced in the window of 9hours+ and updated will have to wrong version
Comment 5 Chris Gianelloni (RETIRED) gentoo-dev 2004-07-11 15:05:25 UTC
There is no reason to revision bump every change... especially ones like this... if you look at the previous versions of vmware, the update was not run at all.  Therefore, the "broken" behavior was no different that previous ebuilds, which worked for many people.  Since this only affected people which it did not work for, there is no reason to version bump and force *everyone* to reinstall.

I only version bump when it affects all (or a majority) of users, or is something deemed a "necessary" upgrade, such as a security fix or a fairly significant change to the package.  This was not, especially as only a minority of our users even use 2.6 kernels.

The problem, is, and has been, fixed.  Do an emerge sync and enjoy the fixed goodness.
Comment 6 Thomas Matthijs (RETIRED) gentoo-dev 2004-07-12 05:25:13 UTC
so you don't want to fix it because of a reasons that it was broken before?
that just doesn't make sense to me

the same ebuild version should never install diffrend versions
Comment 7 Chris Gianelloni (RETIRED) gentoo-dev 2004-07-12 07:00:14 UTC
Look... I'm really trying to not be rude, but this is my final answer and comment on this.

There is a fixed ebuild in portage.  Use it.

I am not going to revision bump the ebuild.  I see no point, and I am the maintainer.  I understand that you disagree with my decision, and I respect that, but you also have to respect that I have made a decision on this and accept it.

Once again, there is nothing to "fix".  There is a correct ebuild in portage.

There is absolutely nothing in Gentoo policy that says that an ebuild must be bumped for minor corrections.  In fact, it plainly states that it is up to the discretion of the maintainer.  I am the maintainer.  My discretion is to not bump it.

I'm sorry that you disagree, but that is life.
Comment 8 Thomas Matthijs (RETIRED) gentoo-dev 2004-07-12 10:33:12 UTC
ok sorry if i offended you, i respect your decision, just trying to make my point, i could be wrong, and offcourse its finialy up to you

i'll drop this now