Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 566396 - kernel-2.eclass: References ${FILESDIR}/.. which violates PMS
Summary: kernel-2.eclass: References ${FILESDIR}/.. which violates PMS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal major (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-21 16:43 UTC by Michał Górny
Modified: 2016-12-26 15:53 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-11-21 16:43:52 UTC
All paths provided by the PMS are intended to use top-down. Going above FILESDIR is disallowed. Not to mention this particular use case makes no real sense:

    if [[ ! -f ${S}/patches.txt ]]; then                                         
        # patches.txt is empty so lets use our ChangeLog                         
        [[ -f ${FILESDIR}/../ChangeLog ]] && \                                   
            echo "Please check the ebuild ChangeLog for more details." \         
            > "${S}"/patches.txt                                                 
    fi

So, the installed package will reference ChangeLogs on install system depending on whether build system had ChangeLogs...
Comment 1 Mike Pagano gentoo-dev 2016-12-26 15:53:56 UTC
From afc71d7a13428d612ad2e890ee978d6040e6bba7 Mon Sep 17 00:00:00 2001
From: Mike Pagano <mpagano@gentoo.org>
Date: Mon, 26 Dec 2016 10:45:13 -0500
Subject: kernel-2.eclass: Remove code that looks for Changelog which is also
 breaks PMS rules going above FILESDIR.