Using authplugins ident and ip at one filterport is broken. Doing so dansguardian always uses the last authplugin configured at dansguardian.conf. I assume that this is a regression introduced with the new multi filterport feature. The attached patch fixes the bug for me. Reproducible: Always Steps to Reproduce: 1. /etc/dansguardian/dansguardian.conf is configured to use ident, then ip authplugin = '/etc/dansguardian/authplugins/ident.conf' authplugin = '/etc/dansguardian/authplugins/ip.conf' 2. Checking this turns out that ident auth does not work. 3. Change authplugins order at dansguardian.conf 4. Now ident works put ip does not.
Created attachment 417370 [details, diff] overlay with patch
Hello Robby, thanks for the patch. Dansguardian currently has no maintainer, are you willing to proxy maintain it?
Could you please give some advise on what a proxy maintainer is expected to do? I have no insight into dansguardian app. Just fixed this issue, because I need it to work again.
There is the proxy maintainers team that on behalf of users commit patches to portage. Check out https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you wish your patches to reach portage.
There is no response from upstream about this bug and moreover I did not got an answer to my email asking about dansguardian further development. As "it is important to have prior knowledge about the package" to become a proxy maintainer I have to decline unfortunately. I'll inform you if this situation has been changed.
Robby, I recently submitted an ebuild for e2guardian (bug 572734) which is an actively maintained fork of DansGuardian. You may be interested in testing out e2guardian and seeing if it is affected by the same issue since it is a fork of DansGuardian.
Since dansguardian is going to be removed from portage soon, that seems like a reasonable way.
Patrick, my patch applies at net-proxy/dansguardian-2.12.0.3-r2. If your fork is based on this version and this bug is not explicitly fixed at your fork, I assume to find it at e2guardian too. I'll switch to e2guardian next time I update my server and provide then feedback. Thank you for this fork. You may apply my patch at e2guardian before and let me know how it works. I'd rather like to switch to fixed version of e2guardian.
I didn't write this fork, Robby. I just happened to stumble upon the project and wanted to get it into Portage since DansGuardian hasn't been updated in so long. I'm sure e2guardian's upstream would be responsive -- especially if you have any patches to submit. Because i think it's currently just one guy working on it.
removed
