Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 565356 - www-client/phantomjs-1.9.8 - fails to build
Summary: www-client/phantomjs-1.9.8 - fails to build
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PATCH, UPSTREAM
Depends on:
Blocks:
 
Reported: 2015-11-10 12:11 UTC by .
Modified: 2017-06-04 11:05 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description . 2015-11-10 12:11:58 UTC
build.sh script contains `set -e` and egrep with an invalid regex which results into a non-zero exit status and fail. I've sent a patch upstream - https://github.com/ariya/phantomjs/pull/13722, but it hasn't got accepted yet.

The patch looks like this - https://github.com/rindeal/phantomjs/commit/95d590cdddceca542810fbed0e5a86ab5aaa5575.patch

It probably affects version 2.0.0 as well, because I made the patch against master branch.

P.S. it's funny to see nobody noticed this yet as probably most of you are using the syntax with no blanks (`make -j1`) which is considered bad and kept only for historical reasons according to http://pubs.opengroup.org/onlinepubs/009696899/basedefs/xbd_chap12.html#tag_12_02
Comment 1 . 2015-11-26 10:48:35 UTC
So the upstream patch was rejected, because they have migrated to python now.
Comment 2 Pacho Ramos gentoo-dev 2017-06-04 11:05:56 UTC
is this valid with 2.0.0-r1?